Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting

From	Mark Rutland <mark.rutland@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting
Date	2016-02-05 15:40 +0100
Message-ID	<qYPIe-1t6-13@gated-at.bofh.it> (permalink)
References	<qYy4G-6oS-23@gated-at.bofh.it> <qYy4G-6oS-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 04, 2016 at 11:43:37AM -0800, Laura Abbott wrote:
> 
> With CONFIG_DEBUG_PAGEALLOC, pages do not have the valid bit
> set when free in the buddy allocator. Add an indiciation to
> the page table dumping code that the valid bit is not set,
> 'F' for fault, to make this easier to understand.
> 
> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>

This looks sensible to me, and worked in testing.

Reviewed-by: Mark Rutland <mark.rutland@arm.com>
Tested-by: Mark Rutland <mark.rutland@arm.com>

Mark.

> ---
>  arch/arm64/mm/dump.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/arch/arm64/mm/dump.c b/arch/arm64/mm/dump.c
> index 5a22a11..f381ac9 100644
> --- a/arch/arm64/mm/dump.c
> +++ b/arch/arm64/mm/dump.c
> @@ -90,6 +90,11 @@ struct prot_bits {
>  
>  static const struct prot_bits pte_bits[] = {
>  	{
> +		.mask	= PTE_VALID,
> +		.val	= PTE_VALID,
> +		.set	= " ",
> +		.clear	= "F",
> +	}, {
>  		.mask	= PTE_USER,
>  		.val	= PTE_USER,
>  		.set	= "USR",
> -- 
> 2.5.0
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting Laura Abbott <labbott@fedoraproject.org> - 2016-02-04 20:50 +0100
  Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be faulting Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-02-05 13:10 +0100
  Re: [PATCHv3 3/3] arm64: ptdump: Indicate whether memory should be  faulting Mark Rutland <mark.rutland@arm.com> - 2016-02-05 15:40 +0100

csiph-web