Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1327689
| From | Måns Rullgård <mans@mansr.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver |
| Date | 2016-02-05 14:40 +0100 |
| Message-ID | <qYOMb-P6-35@gated-at.bofh.it> (permalink) |
| References | <qYOMa-P6-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Sebastian Frias <sf84@laposte.net> writes:
> Signed-off-by: Sebastian Frias <sf84@laposte.net>
> ---
> drivers/net/ethernet/aurora/nb8800.c | 19 +++++++++++++++----
> 1 file changed, 15 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/aurora/nb8800.c
> b/drivers/net/ethernet/aurora/nb8800.c
> index ecc4a33..1353fee 100644
> --- a/drivers/net/ethernet/aurora/nb8800.c
> +++ b/drivers/net/ethernet/aurora/nb8800.c
> @@ -1461,10 +1461,21 @@ static int nb8800_probe(struct platform_device
> *pdev)
> }
>
> priv->phy_node = of_parse_phandle(pdev->dev.of_node, "phy-handle", 0);
> - if (!priv->phy_node) {
> - dev_err(&pdev->dev, "no PHY specified\n");
> - ret = -ENODEV;
> - goto err_free_bus;
> + if (!priv->phy_node)
> + {
> + if (of_phy_is_fixed_link(pdev->dev.of_node)) {
> + ret = of_phy_register_fixed_link(pdev->dev.of_node);
> + if (ret < 0) {
> + dev_err(&pdev->dev, "broken fixed-link specification\n");
Line is longer than 80 chars.
> + goto err_free_bus;
> + }
> + priv->phy_node = of_node_get(pdev->dev.of_node);
> + }
> + else {
Wrong brace placement.
> + dev_err(&pdev->dev, "no PHY specified\n");
> + ret = -ENODEV;
> + goto err_free_bus;
> + }
> }
>
> priv->mii_bus = bus;
> --
> 2.1.4
>
--
Måns Rullgård
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 14:40 +0100
Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 14:40 +0100
[PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 14:50 +0100
Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:00 +0100
Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 15:10 +0100
Re: [PATCH v2] net: ethernet: support "fixed-link" DT key/node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:20 +0100
[PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 15:30 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 15:40 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:00 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 16:10 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 16:30 +0100
[PATCH v5] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias <sf84@laposte.net> - 2016-02-08 11:30 +0100
Re: [PATCH v5] net: ethernet: nb8800: support fixed-link DT node Måns Rullgård <mans@mansr.com> - 2016-02-08 14:20 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 11:40 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 14:40 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Mason <slash.tmp@free.fr> - 2016-02-08 15:20 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 15:40 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 15:50 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-08 15:40 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-08 16:00 +0100
Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:30 +0100
[PATCH v4] net: ethernet: nb8800: support fixed-link DT node Sebastian Frias <sf84@laposte.net> - 2016-02-05 16:00 +0100
Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-05 17:00 +0100
Re: [PATCH] net: ethernet: support "fixed-link" DT node on nb8800 driver Måns Rullgård <mans@mansr.com> - 2016-02-05 17:00 +0100
csiph-web