Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327616

Re: [PATCH 10/10] fs: btrfs: Replace CURRENT_TIME by current_fs_time()

Show all headers | View raw

The kernel tester found a dereferencing NULL pointer issue with this patch.

I think this is the fix:

--- a/fs/btrfs/root-tree.c
+++ b/fs/btrfs/root-tree.c
@@ -488,7 +488,7 @@ void btrfs_update_root_times(struct
btrfs_trans_handle *trans,
                             struct btrfs_root *root)
 {
        struct btrfs_root_item *item = &root->root_item;
-       struct timespec ct = current_fs_time(root->ino_cache_inode->i_sb);
+       struct timespec ct = current_fs_time(root->fs_info->sb);


I will test and re-post the patch.

-Deepa

On Thu, Feb 4, 2016 at 6:14 AM, David Sterba <dsterba@suse.cz> wrote:
> On Tue, Feb 02, 2016 at 10:07:50PM -0800, Deepa Dinamani wrote:
>> CURRENT_TIME macro is not appropriate for filesystems as it
>> doesn't use the right granularity for filesystem timestamps.
>> Use current_fs_time() instead.
>>
>> Signed-off-by: Deepa Dinamani <deepa.kernel@gmail.com>
>> Cc: Chris Mason <clm@fb.com>
>> Cc: Josef Bacik <jbacik@fb.com>
>> Cc: David Sterba <dsterba@suse.com>
>> Cc: linux-btrfs@vger.kernel.org
>
> Reviewed-by: David Sterba <dsterba@suse.com>
>
> There's no actual change for btrfs as it uses granularity 1 which is a
> no-op and equivalent to CURRENT_TIME.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] Remove CURRENT_TIME and CURRENT_TIME_SEC - PART 1 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
  [PATCH 07/10] fs: ext4: Replace CURRENT_TIME with ext4_current_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
  [PATCH 01/10] fs: Add current_fs_time_sec() function Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
  [PATCH 02/10] vfs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
  [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
    Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() "Yan, Zheng" <ukernel@gmail.com> - 2016-02-03 15:40 +0100
      Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by  ktime_get_real_ts() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 17:20 +0100
        Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:30 +0100
          Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() "Yan, Zheng" <zyan@redhat.com> - 2016-02-04 03:10 +0100
            Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Arnd Bergmann <arnd@arndb.de> - 2016-02-04 09:40 +0100
              Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Ilya Dryomov <idryomov@gmail.com> - 2016-02-04 10:10 +0100
                Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Arnd Bergmann <arnd@arndb.de> - 2016-02-04 14:40 +0100
                Re: [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Gregory Farnum <gfarnum@redhat.com> - 2016-02-04 16:30 +0100
                Re: [Y2038] [PATCH 09/10] fs: ceph: Replace CURRENT_TIME by ktime_get_real_ts() Arnd Bergmann <arnd@arndb.de> - 2016-02-04 22:10 +0100
  [PATCH 08/10] fs: ceph: replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
    Re: [PATCH 08/10] fs: ceph: replace CURRENT_TIME by current_fs_time() "Yan, Zheng" <zyan@redhat.com> - 2016-02-03 07:30 +0100
  [PATCH 10/10] fs: btrfs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-03 07:20 +0100
    Re: [PATCH 10/10] fs: btrfs: Replace CURRENT_TIME by  current_fs_time() David Sterba <dsterba@suse.cz> - 2016-02-04 15:20 +0100
      Re: [PATCH 10/10] fs: btrfs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-05 12:40 +0100
        [PATCH v2 10/10] fs: btrfs: Replace CURRENT_TIME by current_fs_time() Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-07 09:00 +0100
          Re: [PATCH v2 10/10] fs: btrfs: Replace CURRENT_TIME by  current_fs_time() David Sterba <dsterba@suse.cz> - 2016-02-08 16:10 +0100
  Re: [Y2038] [PATCH 00/10] Remove CURRENT_TIME and CURRENT_TIME_SEC - PART 1 Arnd Bergmann <arnd@arndb.de> - 2016-02-03 22:40 +0100
    Re: [Y2038] [PATCH 00/10] Remove CURRENT_TIME and CURRENT_TIME_SEC -  PART 1 Deepa Dinamani <deepa.kernel@gmail.com> - 2016-02-04 06:00 +0100

csiph-web