Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1327583
| From | Michal Marek <mmarek@suse.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure |
| Date | 2016-02-05 11:00 +0100 |
| Message-ID | <qYLlg-6Xi-19@gated-at.bofh.it> (permalink) |
| References | <qYvJw-4Y7-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 2016-02-04 18:09, Ard Biesheuvel wrote:
> - ${NM} -n ${1} | \
> - scripts/kallsyms ${kallsymopt} | \
> - ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -
> + # capture the return code of scripts/kallsyms in $RC
> + local RC=`(${NM} -n ${1} | \
> + (scripts/kallsyms ${kallsymopt}; echo $? 1>&3) | \
> + ${CC} ${aflags} -c -o ${2} -x assembler-with-cpp -) 3>&1`
> +
> + [ $RC -eq 0 ]
This now ignores errors by the assembler (and makes the function hard to
read). Please change it to use a temporary file.
Michal
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-02-04 18:20 +0100 Re: [PATCH] scripts/link-vmlinux.sh: force error on kallsyms failure Michal Marek <mmarek@suse.cz> - 2016-02-05 11:00 +0100
csiph-web