Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool

From	Kees Cook <keescook@chromium.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool
Date	2016-02-05 00:20 +0100
Message-ID	<qYBlU-lJ-19@gated-at.bofh.it> (permalink)
References	<qYzk6-7oW-13@gated-at.bofh.it> <qYzk6-7oW-19@gated-at.bofh.it> <qYBcf-i9-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Feb 4, 2016 at 3:00 PM, Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Thu, Feb 4, 2016 at 11:00 PM, Kees Cook <keescook@chromium.org> wrote:
>> Add support for "on" and "off" when converting to boolean.
>>
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>> ---
>>  lib/kstrtox.c | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/lib/kstrtox.c b/lib/kstrtox.c
>> index e18f088704d7..09e83a19a96d 100644
>> --- a/lib/kstrtox.c
>> +++ b/lib/kstrtox.c
>> @@ -347,6 +347,20 @@ int kstrtobool(const char *s, unsigned int base, bool *res)
>
> Forgot update description?

Argh, thank you. Good eye. Sent another update.

-Kees

>
>>         case '0':
>>                 *res = false;
>>                 return 0;
>> +       case 'o':
>> +       case 'O':
>> +               switch (s[1]) {
>> +               case 'n':
>> +               case 'N':
>> +                       *res = true;
>> +                       return 0;
>> +               case 'f':
>> +               case 'F':
>> +                       *res = false;
>> +                       return 0;
>> +               default:
>> +                       break;
>> +               }
>>         default:
>>                 break;
>>         }
>> --
>> 2.6.3
>>
>
>
>
> --
> With Best Regards,
> Andy Shevchenko



-- 
Kees Cook
Chrome OS & Brillo Security

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool Kees Cook <keescook@chromium.org> - 2016-02-04 22:10 +0100
  Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-02-05 00:10 +0100
    Re: [PATCH v2 3/4] lib: add "on"/"off" support to kstrtobool Kees Cook <keescook@chromium.org> - 2016-02-05 00:20 +0100

csiph-web