Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1327223

Re: [PATCH v3.1] firmware: clean up filesystem load exit path

Path csiph.com!goblin3!goblin2!goblin.stu.neva.ru!gothmog.csi.it!bofh.it!news.nic.it!robomod
From "Luis R. Rodriguez" <mcgrof@suse.com>
Newsgroups linux.kernel
Subject Re: [PATCH v3.1] firmware: clean up filesystem load exit path
Date Thu, 04 Feb 2016 23:10:02 +0100
Message-ID <qYAga-84a-15@gated-at.bofh.it> (permalink)
References <qYztL-7sP-5@gated-at.bofh.it>
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
User-Agent Mutt/1.5.21 (2010-09-15)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 20
Organization linux.* mail to news gateway
X-Original-Cc Mimi Zohar <zohar@linux.vnet.ibm.com>, "Luis R. Rodriguez" <mcgrof@kernel.org>, Josh Boyer <jwboyer@fedoraproject.org>, David Howells <dhowells@redhat.com>, linux-kernel@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>, Dmitry Torokhov <dmitry.torokhov@gmail.com>, Dmitry Kasatkin <dmitry.kasatkin@gmail.com>, Eric Biederman <ebiederm@xmission.com>, Rusty Russell <rusty@rustcorp.com.au>, linux-security-module@vger.kernel.org, kexec@lists.infradead.org, linux-modules@vger.kernel.org
X-Original-Date Thu, 4 Feb 2016 23:01:22 +0100
X-Original-Message-ID <20160204220122.GL12481@wotan.suse.de>
X-Original-References <20160204211501.GA14755@www.outflux.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1327223

Show key headers only | View raw


On Thu, Feb 04, 2016 at 01:15:02PM -0800, Kees Cook wrote:
> This makes the error and success paths more readable while trying to
> load firmware from the filesystem.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> Cc: Josh Boyer <jwboyer@fedoraproject.org>
> Cc: David Howells <dhowells@redhat.com>
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>

Thanks,

Acked-by: Luis R. Rodriguez <mcgrof@kernel.org>

> ---
> Suggested as an alternative to "[PATCH v3 06/22] firmware: fold successful fw read early"

Mimi, feel free to pick up as a replacement in your series.

  Luis

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v3.1] firmware: clean up filesystem load exit path Kees Cook <keescook@chromium.org> - 2016-02-04 22:20 +0100
  Re: [PATCH v3.1] firmware: clean up filesystem load exit path "Luis R. Rodriguez" <mcgrof@suse.com> - 2016-02-04 23:10 +0100
    Re: [PATCH v3.1] firmware: clean up filesystem load exit path Mimi Zohar <zohar@linux.vnet.ibm.com> - 2016-02-05 01:00 +0100

csiph-web