Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1327256

Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq() error code

Show all headers | View raw

On 04/02/2016 at 09:26:35 +0900, Krzysztof Kozlowski wrote :
> The regmap_irq_get_virq() can return 0 or -EINVAL in error conditions
> but driver checked only for value of 0.
> 
> This could lead to a cast of -EINVAL to an unsigned int used as a
> interrupt number for devm_request_threaded_irq(). Although this is not
> yet fatal (devm_request_threaded_irq() will just fail with -EINVAL) but
> might be a misleading when diagnosing errors.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Fixes: 6f1c1e71d933 ("mfd: max77686: Convert to use regmap_irq")
> 
> ---
> 
> Patch rebased on current mainline, not RTC tree, because IMHO it is
> a candidate for current RC-cycle.
> 
> Not marking cc-stable because behavior is not fatal - unless there is
> an interrupt with number 4294967274 (then it would be successfully
> requested for RTC driver).
> ---
>  drivers/rtc/rtc-max77686.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] rtc: max77686: Properly handle regmap_irq_get_virq() error code Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-02-04 01:30 +0100
  Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq()  error code Javier Martinez Canillas <javier@osg.samsung.com> - 2016-02-04 03:50 +0100
  Re: [PATCH] rtc: max77686: Properly handle regmap_irq_get_virq()  error code Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-02-04 23:50 +0100

csiph-web