Re: [PATCH v7 5/9] virtio_ring: Support DMA APIs

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Andy Lutomirski <luto@amacapital.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH v7 5/9] virtio_ring: Support DMA APIs
Date	Wed, 03 Feb 2016 19:00:03 +0100
Message-ID	<qY9SH-58b-29@gated-at.bofh.it> (permalink)
References	<qXYud-6cO-3@gated-at.bofh.it> <qXYuf-6cO-19@gated-at.bofh.it> <qY68s-2Gi-23@gated-at.bofh.it>
X-Original-To	"Michael S. Tsirkin" <mst@redhat.com>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=amacapital-net.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=WW4TmCPwM4jXySvJFStsMNLoKO22W7m9kneeOSpyg1A=; b=Q6miTMssi1oFCWf95V3Gna1PnL1idWeIqbLF7PlDMds2OXGHWLkwhcRolbVrIQmaf1 zM4yiii4huxzIrmzcgEFF+TiNekaxQuBB6U+V1gHmcCIUna1o1Z6JV+wivhKWSdgGfN7 BV1LUzNwUc8olk7qPXPrN4eFKmpi0oKI8FyTFa659PS5019faCmNTiB6gnz1iTT9FCYI 35Mu40XzE6gbmJPSWnNSqyZ4U6/DtdqzCzZ6lgM1Rc7L0ERBz/ztgMoqtQ5McAY86XaK Hlb/EL4TDitpR5vAGqLKZIKHy5Gdsoi9vchfZLLNj4gj3yb2r01mod1dC6X+sxhRFCoP vmxQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type; bh=WW4TmCPwM4jXySvJFStsMNLoKO22W7m9kneeOSpyg1A=; b=GfI2fSsO/gwOfmgMnEliSbC8DqWhtUoBkHlBKLJzKSew6t8JVQizewxIwqrvOVhCV1 OU7vL3S7+5JCItNZ016Y2Kwt7UEdmgBUXI4vRS/P8HwlLwDq2QIvWcp3DuWpjsXCz2l5 Eo6uOdzOFwHmwJHw3N+dM8jpS5ggCNoW/ApJupD28Nt3VtI4ERgg4svmg9iY9i+M/4ix neIigVn1tVLbnyvEcP4hV/2kbOo3oqK5ISpqAZ1P+XU7zpD2r6vG8SBZxGngQ4s/Gfq3 DTME+o/ScbgCsWtAeR7wpyjs5Z09n60R186c+RGTPXTyOfdPSb2CICLWU/rCRLwY7PJ9 uWig==
X-Gm-Message-State	AG10YOSWaD84xa4aCK+H08zo0TVfHkM6wqYuuMkXWLVek9+NI4CcIellEWy5IpxbH1Wz9dvzM4EQIg7i77JCaqna
X-Received	by 10.60.78.105 with SMTP id a9mr3568909oex.76.1454522038961; Wed, 03 Feb 2016 09:53:58 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	46
Organization	linux.* mail to news gateway
X-Original-Cc	Christian Borntraeger <borntraeger@de.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, David Woodhouse <dwmw2@infradead.org>, "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>, Martin Schwidefsky <schwidefsky@de.ibm.com>, Sebastian Ott <sebott@linux.vnet.ibm.com>, "David S. Miller" <davem@davemloft.net>, linux-s390 <linux-s390@vger.kernel.org>, David Vrabel <david.vrabel@citrix.com>, Cornelia Huck <cornelia.huck@de.ibm.com>, Joerg Roedel <jroedel@suse.de>, KVM <kvm@vger.kernel.org>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, Christoph Hellwig <hch@lst.de>, Linux Virtualization <virtualization@lists.linux-foundation.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, sparclinux@vger.kernel.org
X-Original-Date	Wed, 3 Feb 2016 09:53:39 -0800
X-Original-Message-ID	<CALCETrWXPEMTTTD3raO6uOF+WG+msszRXQY5QMhBf+UwF5kArw@mail.gmail.com>
X-Original-References	<cover.1454477782.git.luto@kernel.org> <a6c1a2d0b3ea60bfb27c810896179bd553e7e240.1454477782.git.luto@kernel.org> <20160203154633-mutt-send-email-mst@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1325750

Show key headers only | View raw

On Feb 3, 2016 5:52 AM, "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> On Tue, Feb 02, 2016 at 09:46:36PM -0800, Andy Lutomirski wrote:
> > virtio_ring currently sends the device (usually a hypervisor)
> > physical addresses of its I/O buffers.  This is okay when DMA
> > addresses and physical addresses are the same thing, but this isn't
> > always the case.  For example, this never works on Xen guests, and
> > it is likely to fail if a physical "virtio" device ever ends up
> > behind an IOMMU or swiotlb.
> >
> > The immediate use case for me is to enable virtio on Xen guests.
> > For that to work, we need vring to support DMA address translation
> > as well as a corresponding change to virtio_pci or to another
> > driver.
> >
> > Signed-off-by: Andy Lutomirski <luto@kernel.org>
> > ---
> >  drivers/virtio/Kconfig           |   2 +-
> >  drivers/virtio/virtio_ring.c     | 200 ++++++++++++++++++++++++++++++++-------
> >  tools/virtio/linux/dma-mapping.h |  17 ++++
> >  3 files changed, 183 insertions(+), 36 deletions(-)
> >  create mode 100644 tools/virtio/linux/dma-mapping.h
> >
> > diff --git a/drivers/virtio/Kconfig b/drivers/virtio/Kconfig
> > index cab9f3f63a38..77590320d44c 100644
> > --- a/drivers/virtio/Kconfig
> > +++ b/drivers/virtio/Kconfig
> > @@ -60,7 +60,7 @@ config VIRTIO_INPUT
> >
> >   config VIRTIO_MMIO
> >       tristate "Platform bus driver for memory mapped virtio devices"
> > -     depends on HAS_IOMEM
> > +     depends on HAS_IOMEM && HAS_DMA
> >       select VIRTIO
> >       ---help---
> >        This drivers provides support for memory mapped virtio
>
> What's this chunk doing here btw? Should be part of the mmio patch?
>

IIRC it was deliberate.  Making virtio depend on HAS_DMA didn't work
right because kconfig doesn't propagate dependencies through select
intelligently.  This patch makes core virtio depend on HAS_DMA, so I
added the dependency here, too.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v7 5/9] virtio_ring: Support DMA APIs Andy Lutomirski <luto@kernel.org> - 2016-02-03 06:50 +0100
  Re: [PATCH v7 5/9] virtio_ring: Support DMA APIs "Michael S. Tsirkin" <mst@redhat.com> - 2016-02-03 15:00 +0100
    Re: [PATCH v7 5/9] virtio_ring: Support DMA APIs Andy Lutomirski <luto@amacapital.net> - 2016-02-03 19:00 +0100

csiph-web