Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1325670
| From | Gregory CLEMENT <gregory.clement@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port |
| Date | 2016-02-03 17:50 +0100 |
| Message-ID | <qY8MY-4sb-65@gated-at.bofh.it> (permalink) |
| References | <qXNyN-6U3-3@gated-at.bofh.it> <qXNyP-6U3-23@gated-at.bofh.it> <qY0FI-7K9-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Marcin,
On mer., févr. 03 2016, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Gregory
>
>> +
>> +static int mvebu_uart_startup(struct uart_port *port)
>> +{
>> + int ret;
>> +
>> + writel(CTRL_TXFIFO_RST | CTRL_RXFIFO_RST,
>> + port->membase + UART_CTRL);
>> + udelay(1);
>> + writel(CTRL_RX_INT, port->membase + UART_CTRL);
>> +
>> + ret = request_irq(port->irq, mvebu_uart_isr, port->irqflags, "serial",
>> + port);
>> + if (ret) {
>> + dev_err(port->dev, "failed to request irq\n");
>> + return ret;
>> + }
>> +
>> + return 0;
>> +}
>> +
>
>> +static int mvebu_uart_probe(struct platform_device *pdev)
>> +{
>> + struct resource *reg = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> + struct resource *irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
>> + struct uart_port *port;
>> + struct mvebu_uart_data *data;
>> + int ret;
>> +
>> + if (!reg || !irq) {
>> + dev_err(&pdev->dev, "no registers/irq defined\n");
>> + return -EINVAL;
>> + }
>> +
>> + port = &mvebu_uart_ports[0];
>> +
>> + spin_lock_init(&port->lock);
>> +
>> + port->dev = &pdev->dev;
>> + port->type = PORT_MVEBU;
>> + port->ops = &mvebu_uart_ops;
>> + port->regshift = 0;
>> +
>> + port->fifosize = 32;
>> + port->iotype = UPIO_MEM32;
>> + port->flags = UPF_FIXED_PORT;
>> + port->line = 0; /* single port: force line number to 0 */
>> +
>> + port->irq = irq->start;
>> + port->irqflags = 0;
>
> Please use port->irqflags = IRQF_SHARED;
> As ubuntu opens multiple consoles A3700 can't boot to it (only to
> buildroot with single console).
But this irq is not shared, this looks like a hack hidding the real
issue.
Gregory
>
> Best regards,
> Marcin
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 00/10] Add support for the Armada 3700 SoC an mvebu ARM64 based Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:10 +0100
[PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:10 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Mark Rutland <mark.rutland@arm.com> - 2016-02-02 19:30 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Mark Rutland <mark.rutland@arm.com> - 2016-02-02 19:30 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk> - 2016-02-02 19:30 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 17:10 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Mark Rutland <mark.rutland@arm.com> - 2016-02-02 19:40 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 17:40 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 18:00 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Mark Rutland <mark.rutland@arm.com> - 2016-02-03 18:10 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Arnd Bergmann <arnd@arndb.de> - 2016-02-02 22:10 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 17:50 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Rob Herring <robh@kernel.org> - 2016-02-02 22:20 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Marcin Wojtas <mw@semihalf.com> - 2016-02-03 09:10 +0100
Re: [PATCH 01/10] serial: mvebu-uart: initial support for Armada-3700 serial port Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 17:50 +0100
[PATCH 04/10] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
Re: [PATCH 04/10] Documentation: dt-bindings: Add a new compatible for the Armada 3700 Rob Herring <robh@kernel.org> - 2016-02-02 22:30 +0100
[PATCH 08/10] MAINTAINERS: Extend dts entry for ARM64 mvebu files Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
[PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
Re: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Mark Rutland <mark.rutland@arm.com> - 2016-02-02 19:40 +0100
Re: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 11:50 +0100
Re: [PATCH 07/10] arm64: dts: add the Marvell Armada 3700 family and a development board Jisheng Zhang <jszhang@marvell.com> - 2016-02-03 07:50 +0100
[PATCH 02/10] ata: ahci_mvebu: add support for Armada 3700 variant Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
[PATCH 09/10] Documentation: arm: update supported Marvell EBU processors Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
[PATCH 10/10] arm64: defconfig: enable Armada 3700 related config Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
[PATCH 06/10] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
Re: [PATCH 06/10] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Rob Herring <robh@kernel.org> - 2016-02-02 22:30 +0100
Re: [PATCH 06/10] devicetree: bindings: add DT binding for the Marvell Armada 3700 SoC family Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 09:10 +0100
[PATCH 03/10] arm64: add Armada 3700 architecture entry Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-02 19:20 +0100
Re: [PATCH 03/10] arm64: add Armada 3700 architecture entry Jisheng Zhang <jszhang@marvell.com> - 2016-02-03 07:30 +0100
Re: [PATCH 03/10] arm64: add Armada 3700 architecture entry Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 09:00 +0100
Re: [PATCH 03/10] arm64: add Armada 3700 architecture entry Arnd Bergmann <arnd@arndb.de> - 2016-02-03 10:20 +0100
Re: [PATCH 03/10] arm64: add Armada 3700 architecture entry Gregory CLEMENT <gregory.clement@free-electrons.com> - 2016-02-03 12:20 +0100
csiph-web