Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1325552

Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection

From Don Zickus <dzickus@redhat.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection
Date 2016-02-03 16:50 +0100
Message-ID <qY7QS-3Om-3@gated-at.bofh.it> (permalink)
References <qXz2O-3Wf-21@gated-at.bofh.it> <qXz2P-3Wf-53@gated-at.bofh.it> <qXN5L-6qA-3@gated-at.bofh.it> <qXRVM-1tU-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Feb 02, 2016 at 03:40:34PM -0700, Jeffrey Merkey wrote:
> >
> > Please remember to add version history, so I can tell what changed.
> >
> 
> What command do I give to git when it creates the patch from git
> format-patch that outputs what you are looking for or do I have to add
> that manually.  The diff of files changed?

Sorry I forgot to respond to this part.  This is usually just a manual text
that folks add to explain what changed between different versions of the
patch.  It is difficult to re-review a patch from scratch all the time.  It
is nice to have a little blurb stating what changed to help focus my review.

Now this patch is small enough, it doesn't matter, but it is a nice habit to
get into.

Cheers,
Don

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-02 03:40 +0100
  Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Don Zickus <dzickus@redhat.com> - 2016-02-02 18:40 +0100
    Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-02 23:50 +0100
      Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-03 05:20 +0100
        Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-03 05:40 +0100
      Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Don Zickus <dzickus@redhat.com> - 2016-02-03 16:50 +0100
        Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-03 18:30 +0100
      Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Don Zickus <dzickus@redhat.com> - 2016-02-03 16:50 +0100
        Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-03 18:30 +0100
          Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-03 21:20 +0100
            Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Jeffrey Merkey <jeffmerkey@gmail.com> - 2016-02-04 03:50 +0100
          Re: [PATCH v5 3/3] Add BUG_XX() debugging hard/soft lockup detection Don Zickus <dzickus@redhat.com> - 2016-02-03 21:20 +0100

csiph-web