Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths
Date	2016-02-03 14:30 +0100
Message-ID	<qY5Fp-2vi-21@gated-at.bofh.it> (permalink)
References	(1 earlier) <qXtqq-8iB-13@gated-at.bofh.it> <qXuZb-112-3@gated-at.bofh.it> <qXviy-17S-25@gated-at.bofh.it> <qXvsd-1cZ-11@gated-at.bofh.it> <qY2Hx-DD-49@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 3 Feb 2016 11:12:09 +0100
Ingo Molnar <mingo@kernel.org> wrote:

> * Peter Zijlstra <peterz@infradead.org> wrote:
> 
> > On Mon, Feb 01, 2016 at 05:38:09PM -0500, Steven Rostedt wrote:
> >   
> > > Regardless of this final patch, what do you think of the first three? I
> > > can send them as a separate series, just to get more of the SCHED_DEBUG
> > > code into debug.c.  
> > 
> > The first two looked ok, the third I had a vague niggle it might be part
> > of something bigger and tearing it up like this might make it harder.  

Actually, I originally had plans to display the entire root domain
here, but decided against that.

> 
> Yeah, so the purpose of kernel/sched/debug.c is mostly meant as a filesystem 
> interface to display various internal scheduler details. It mostly deals with 
> /proc/sched_debug details: hence the name.
> 
> Note that 'sched domain debugging' does not fit into that cleanly, because it also 
> does sanity checking of the sched-domains data. So I'm not sure we want to do 
> patch #3 that moves sched-domain debugging to debug.c.
> 
> So debug.c is named in a bit too generic fashion, attracting such patches.
> 

It was actually more the #ifdef SCHED_DEBUG that attracted the patches.
The debug.c file is compiled on SCHED_DEBUG, thus it appeared natural
to have parts in core.c just moved into that file instead of having all
the #ifdef SCHED_DEBUG in it.

-- Steve

Thread

[RFC][PATCH 0/4] sched: Display deadline bandwidth and other SCHED_DEBUG clean up Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 21:30 +0100
  [RFC][PATCH 1/4] sched: Move sched_feature file setup into debug.c Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 21:40 +0100
  [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to show current bandwidths Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 21:40 +0100
    Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Peter Zijlstra <peterz@infradead.org> - 2016-02-01 23:20 +0100
      Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 23:40 +0100
        Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Peter Zijlstra <peterz@infradead.org> - 2016-02-01 23:50 +0100
          Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Ingo Molnar <mingo@kernel.org> - 2016-02-03 11:20 +0100
            Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Steven Rostedt <rostedt@goodmis.org> - 2016-02-03 14:30 +0100
    Re: [RFC][PATCH 4/4] sched: Add debugfs/sched/deadline_bw file to  show current bandwidths Peter Zijlstra <peterz@infradead.org> - 2016-02-01 23:20 +0100
  [RFC][PATCH 2/4] sched: Move sched_domain_sysctl to debug.c Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 21:40 +0100
  [RFC][PATCH 3/4] sched: Move sched_domain_debug into debug.c Steven Rostedt <rostedt@goodmis.org> - 2016-02-01 21:40 +0100

csiph-web