Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324993

Re: + x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch added to -mm tree

Show all headers | View raw

* akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:

> diff -puN arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes arch/x86/include/asm/pgtable_64.h
> --- a/arch/x86/include/asm/pgtable_64.h~x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes
> +++ a/arch/x86/include/asm/pgtable_64.h
> @@ -111,8 +111,10 @@ static inline pud_t native_pudp_get_and_
>  #ifdef CONFIG_SMP
>  	return native_make_pud(xchg(&pudp->pud, 0));
>  #else
> -	/* native_local_pudp_get_and_clear,
> -	   but duplicated because of cyclic dependency */
> +	/*
> +	 * native_local_pudp_get_and_clear, but duplicated because of cyclic
> +	 * dependency
> +	 */
>  	pud_t ret = *pudp;
>  	native_pud_clear(pudp);
>  	return ret;

When referring to functions in comments (or changelogs) please use () to make it 
clear on sight what is being referred to.

Also, please try to construct proper English sentences with verbs and such!

I.e. something like this would work for me:

> +	/*
> +	 * This is a duplicate of native_local_pudp_get_and_clear(),
> +	 * because we cannot use the original due to a cyclic header
> +	 * file dependency:
> +	 */

(Assuming I managed to decode the shorthand form properly.)

Thanks,

	Ingo

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: +  x86-add-support-for-pud-sized-transparent-hugepages-checkpatch-fixes.patch  added to -mm tree Ingo Molnar <mingo@kernel.org> - 2016-02-03 08:50 +0100

csiph-web