[PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name

Path	csiph.com!au2pb.net!feeder.erje.net!2.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Chunyan Zhang <zhang.chunyan@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name
Date	Wed, 03 Feb 2016 09:20:02 +0100
Message-ID	<qY0Po-7NH-5@gated-at.bofh.it> (permalink)
References	<qY0Po-7NH-7@gated-at.bofh.it>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=f733EETAzF8qfBJJSjhFbEY8DPyinVAzvIQ7/GZG+0w=; b=eUEOEzK3tl2cTpnZfnArvgp4bJkzwxKuco8ycYEAquHpjg4lJr+dWd6IbGFE5qfInr BY103UHwrgTwdewuaSeRJW17ta+BpzFxBH2qlUVXGUqqa3FScxLJty86e+SRDZXuf/aW a50EN7CnSz07BEo7v856ihvG+qTKOHUmqympI=
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=f733EETAzF8qfBJJSjhFbEY8DPyinVAzvIQ7/GZG+0w=; b=Bek2ojsInmo0g9DNFBNy+mXneU12R1fTB14Jrr4FsaHPMOtNI7E0AXnOK1Sc0fw0Zy 8qQyCDrVOuHi4pFq4hiEPWrMZTTsJjJznklcZqDerkxMgrId2q1NBCu0K/dfWDt5OUpw 85CzY6VmR4nGu1ym70E6PQvzZ4GZVQUXt/mV8GWzwaUCzQzoJD2upQbzTFOWd65tQwYP D9wAkjeFHawDuXHeqi9wLZvdoksTVgyOTRxv6QBnWpVOYSmaX+yOr/DIDApolAy/Xn0O xfZVYQjLQwPRdjaHVaGkp5MMTjEVs4747XUkxD8pqynoHORiCRtFEzkdjhKv6gQ+35X8 ob8g==
X-Gm-Message-State	AG10YOQTagm1H12WFVKqX+jhiVi6/WeaCjlWb5lOOUDq8RczSk35+L7DLfPdKq2i+rU29YnY
X-Received	by 10.66.122.97 with SMTP id lr1mr322772pab.68.1454487388056; Wed, 03 Feb 2016 00:16:28 -0800 (PST)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	56
Organization	linux.* mail to news gateway
X-Original-Cc	robh@kernel.org, broonie@kernel.org, pratikp@codeaurora.org, nicolas.guion@st.com, corbet@lwn.net, mark.rutland@arm.com, mike.leach@arm.com, tor@ti.com, al.grant@arm.com, zhang.lyra@gmail.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-doc@vger.kernel.org
X-Original-Date	Wed, 3 Feb 2016 16:15:33 +0800
X-Original-Message-ID	<1454487337-30184-3-git-send-email-zhang.chunyan@linaro.org>
X-Original-References	<1454487337-30184-1-git-send-email-zhang.chunyan@linaro.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1325021

Show key headers only | View raw

The node name of STM master management policy is a concatenation of an
STM device name to which this policy applies and following an arbitrary
string, these two strings are concatenated with a dot.

This patch adds a loop for extracting the STM device name when an
arbitrary number of dot(s) are found in this STM device name.

Signed-off-by: Chunyan Zhang <zhang.chunyan@linaro.org>
---
 drivers/hwtracing/stm/policy.c | 27 ++++++++++++++++-----------
 1 file changed, 16 insertions(+), 11 deletions(-)

diff --git a/drivers/hwtracing/stm/policy.c b/drivers/hwtracing/stm/policy.c
index 11ab6d0..691686e 100644
--- a/drivers/hwtracing/stm/policy.c
+++ b/drivers/hwtracing/stm/policy.c
@@ -321,21 +321,26 @@ stp_policies_make(struct config_group *group, const char *name)
 	/*
 	 * node must look like <device_name>.<policy_name>, where
 	 * <device_name> is the name of an existing stm device and
-	 * <policy_name> is an arbitrary string
+	 * <policy_name> is an arbitrary string, when an arbitrary
+	 * number of dot(s) are found in the <device_name>, the
+	 * first matched STM device name would be extracted.
 	 */
-	p = strchr(devname, '.');
-	if (!p) {
-		kfree(devname);
-		return ERR_PTR(-EINVAL);
-	}
+	for (p = devname; ; p++) {
+		p = strchr(p, '.');
+		if (!p) {
+			kfree(devname);
+			return ERR_PTR(-EINVAL);
+		}
 
-	*p++ = '\0';
+		*p = '\0';
 
-	stm = stm_find_device(devname);
-	kfree(devname);
+		stm = stm_find_device(devname);
+		if (stm)
+			break;
+		*p = '.';
+	};
 
-	if (!stm)
-		return ERR_PTR(-ENODEV);
+	kfree(devname);
 
 	mutex_lock(&stm->policy_mutex);
 	if (stm->policy) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name Chunyan Zhang <zhang.chunyan@linaro.org> - 2016-02-03 09:20 +0100
  [PATCH] stm class: fix semicolon.cocci warnings kbuild test robot <lkp@intel.com> - 2016-02-03 11:20 +0100
  Re: [PATCH V2 2/6] stm class: adds a loop to extract the first valid  STM device name kbuild test robot <lkp@intel.com> - 2016-02-03 11:20 +0100
  [PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name Chunyan Zhang <zhang.chunyan@linaro.org> - 2016-02-04 10:00 +0100
    Re: [PATCH V2 2/6] stm class: adds a loop to extract the first valid STM device name Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-02-04 18:40 +0100
      Re: [PATCH V2 2/6] stm class: adds a loop to extract the first valid  STM device name Chunyan Zhang <zhang.chunyan@linaro.org> - 2016-02-05 04:20 +0100

csiph-web