Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Byungchul Park <byungchul.park@lge.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick
Date	Tue, 02 Feb 2016 02:00:02 +0100
Message-ID	<qXxu2-2HC-3@gated-at.bofh.it> (permalink)
References	<qSEcO-8kf-17@gated-at.bofh.it> <qSHkm-1Ws-7@gated-at.bofh.it> <qSJFx-3m2-17@gated-at.bofh.it> <qSN6q-5HE-19@gated-at.bofh.it> <qSTOy-25l-13@gated-at.bofh.it> <qSYbx-51L-33@gated-at.bofh.it> <qVXiW-5U4-7@gated-at.bofh.it> <qWe0q-OA-17@gated-at.bofh.it> <qXjAL-11X-13@gated-at.bofh.it> <qXk3L-1dK-13@gated-at.bofh.it>
X-Original-Senderip	156.147.1.125
X-Original-Mailfrom	byungchul.park@lge.com
X-Original-Senderip	10.177.222.33
X-Original-Mailfrom	byungchul.park@lge.com
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	19
Organization	linux.* mail to news gateway
X-Original-Cc	Frederic Weisbecker <fweisbec@gmail.com>, LKML <linux-kernel@vger.kernel.org>, Chris Metcalf <cmetcalf@ezchip.com>, Thomas Gleixner <tglx@linutronix.de>, Luiz Capitulino <lcapitulino@redhat.com>, Christoph Lameter <cl@linux.com>, "Paul E . McKenney" <paulmck@linux.vnet.ibm.com>, Mike Galbraith <efault@gmx.de>, Rik van Riel <riel@redhat.com>
X-Original-Date	Tue, 2 Feb 2016 09:50:41 +0900
X-Original-Message-ID	<20160202005041.GF29804@X58A-UD3R>
X-Original-References	<20160119130857.GC6344@twins.programming.kicks-ass.net> <20160119162210.GA5317@lerouge> <20160119185647.GA6357@twins.programming.kicks-ass.net> <20160119223320.GD5317@lerouge> <20160120054335.GE9882@X58A-UD3R> <20160120102614.GA5310@X58A-UD3R> <20160128160125.GB25866@lerouge> <20160129095016.GZ6356@twins.programming.kicks-ass.net> <20160201100513.GD29804@X58A-UD3R> <20160201103433.GP6357@twins.programming.kicks-ass.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1323681

Show key headers only | View raw

On Mon, Feb 01, 2016 at 11:34:33AM +0100, Peter Zijlstra wrote:
> On Mon, Feb 01, 2016 at 07:05:13PM +0900, Byungchul Park wrote:
> > On Fri, Jan 29, 2016 at 10:50:16AM +0100, Peter Zijlstra wrote:
> > > On Thu, Jan 28, 2016 at 05:01:26PM +0100, Frederic Weisbecker wrote:
> > > > So lets check all the things we call on scheduler_tick():
> > > > 
> > > > _ sched_clock_tick(): maybe it doesn't need to be called when idle. I'm not sure.
> > > >   Some code in idle (timers, irqs, ...) might need to call sched_clock().
> > > 
> > > Only needed if you've got a shady TSC.
> > 
> > Yeh.. IMO, this can be done without the tick handling during nohz, with the
> > patch I am attaching. Could you check the patch? Or we have to handle it
> > remotely, too. (for a crazy TSC)
> 
> I think NOHZ_FULL already requires the TSC not to be wrecked.

What about the regular NOHZ? Or does not any code in idle call a kind of
sched_lock_cpu() at all?

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Frederic Weisbecker <fweisbec@gmail.com> - 2016-01-28 17:10 +0100
  Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Peter Zijlstra <peterz@infradead.org> - 2016-01-29 11:00 +0100
    Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Byungchul Park <byungchul.park@lge.com> - 2016-02-01 11:10 +0100
      [PATCH] sched: calculate sched_clock_cpu without tick handling during nohz Byungchul Park <byungchul.park@lge.com> - 2016-02-01 11:20 +0100
      Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Peter Zijlstra <peterz@infradead.org> - 2016-02-01 11:40 +0100
        Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Byungchul Park <byungchul.park@lge.com> - 2016-02-02 01:00 +0100
        Re: [PATCH 1/4] sched: Don't account tickless CPU load on tick Byungchul Park <byungchul.park@lge.com> - 2016-02-02 02:00 +0100

csiph-web