Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1323674
| From | Joshua Henderson <joshua.henderson@microchip.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine |
| Date | 2016-02-02 01:40 +0100 |
| Message-ID | <qXxaF-2zt-13@gated-at.bofh.it> (permalink) |
| References | <qXxaF-2zt-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Cristian Birsan <cristian.birsan@microchip.com> Commit 6b6e97107f12f3a9f7 (USB: musb: fix isochronous TXDMA (take 2)) introduces a problem setting the desired channel mode for the Mentor DMA engine. There is a case where the pointer of the channel DMA mode is incorrectly assigned to a pointer value, when it should be assigned the actual mode value. This results in the value of channel->desired_mode not being correct. Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com> Signed-off-by: Joshua Henderson <joshua.henderson@microchip.com> --- drivers/usb/musb/musb_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c index 3fdc99b..748379e 100644 --- a/drivers/usb/musb/musb_host.c +++ b/drivers/usb/musb/musb_host.c @@ -662,7 +662,7 @@ static int musb_tx_dma_set_mode_mentor(struct dma_controller *dma, csr &= ~(MUSB_TXCSR_AUTOSET | MUSB_TXCSR_DMAMODE); csr |= MUSB_TXCSR_DMAENAB; /* against programmer's guide */ } - channel->desired_mode = mode; + channel->desired_mode = *mode; musb_writew(epio, MUSB_TXCSR, csr); return 0; -- 1.7.9.5
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-02 01:40 +0100
Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-02 14:40 +0100
Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Joshua Henderson <joshua.henderson@microchip.com> - 2016-02-02 17:40 +0100
Re: [PATCH 2/2] usb: musb: Fix DMA desired mode for Mentor DMA engine Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2016-02-02 18:00 +0100
csiph-web