Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323597

[PATCH] sched: Remove unnecessary numa dequeue update from non-SMP kernel

From Tim Chen <tim.c.chen@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH] sched: Remove unnecessary numa dequeue update from non-SMP kernel
Date 2016-02-01 23:50 +0100
Message-ID <qXvsf-1cZ-53@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


In account_entity_enqueue, we do not do account_numa_enqueue
as NUMA balancing is not needed for non-SMP configured kernel.

Hence, we should remove account_numa_dequeue from
account_entity_dequeue for the non-SMP kernel.

Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
---
 kernel/sched/fair.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 56b7d4b..6cbe2fb 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -2405,10 +2405,12 @@ account_entity_dequeue(struct cfs_rq *cfs_rq, struct sched_entity *se)
 	update_load_sub(&cfs_rq->load, se->load.weight);
 	if (!parent_entity(se))
 		update_load_sub(&rq_of(cfs_rq)->load, se->load.weight);
+#ifdef CONFIG_SMP
 	if (entity_is_task(se)) {
 		account_numa_dequeue(rq_of(cfs_rq), task_of(se));
 		list_del_init(&se->group_node);
 	}
+#endif
 	cfs_rq->nr_running--;
 }
 
-- 
1.8.3.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

[PATCH] sched: Remove unnecessary numa dequeue update from non-SMP  kernel Tim Chen <tim.c.chen@linux.intel.com> - 2016-02-01 23:50 +0100

csiph-web