Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323495

Re: [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate

From Matthew Wilcox <willy@linux.intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate
Date 2016-02-01 21:50 +0100
Message-ID <qXtA8-8mr-29@gated-at.bofh.it> (permalink)
References <qWZiG-3dk-3@gated-at.bofh.it> <qWZiH-3dk-23@gated-at.bofh.it> <qXmyC-3iQ-15@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Feb 01, 2016 at 03:10:19PM +0200, Kirill A. Shutemov wrote:
> On Sun, Jan 31, 2016 at 11:19:53PM +1100, Matthew Wilcox wrote:
> > We were a little sloppy about using PAGE_SIZE instead of PAGE_CACHE_SIZE.
> 
> PAGE_CACHE_SIZE is non-sense. It never had any meaning. At least in
> upstream. And only leads to confusion on border between vfs and mm.
> 
> We should just drop it.
> 
> I need to find time at some point to prepare patchset...

I argued in favour of this at last LSFMM and people were ... reluctant.
I think with your map_pages work, the PAGE_CACHE_SIZE idea now has no
potential performance win left.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/6] DAX cleanups Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-31 13:30 +0100
  [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-31 13:30 +0100
    Re: [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-01 14:20 +0100
      Re: [PATCH 4/6] dax: Use PAGE_CACHE_SIZE where appropriate Matthew Wilcox <willy@linux.intel.com> - 2016-02-01 21:50 +0100
  [PATCH 2/6] dax: Remove unnecessary rechecking of i_size Matthew Wilcox <matthew.r.wilcox@intel.com> - 2016-01-31 13:30 +0100

csiph-web