Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy

From	Rik van Riel <riel@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy
Date	2016-02-01 21:10 +0100
Message-ID	<qXsXo-85A-5@gated-at.bofh.it> (permalink)
References	<qXskG-7wZ-5@gated-at.bofh.it> <qXskG-7wZ-19@gated-at.bofh.it> <qXsXo-85A-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 02/01/2016 03:00 PM, Eric Dumazet wrote:
> On Mon, 2016-02-01 at 14:21 -0500, riel@redhat.com wrote:
>> From: Rik van Riel <riel@redhat.com>
>>
> 
>>  #ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
>> +static bool vtime_jiffies_changed(struct task_struct *tsk, unsigned long now)
>> +{
>> +	if (tsk->vtime_jiffies == jiffies)
>> +		return false;
>> +
>> +	tsk->vtime_jiffies = jiffies;
>> +	return true;
>> +}
> 
> I am guessing you intended to use 'now' instead of jiffies ?

Yes indeed. Good catch.

I have fixed this up in my local tree, and will wait for
more people's comments before sending out a v5 (tomorrow?).

-- 
All rights reversed

Thread

[PATCH 4/4] sched,time: only call account_{user,sys,guest,idle}_time once a jiffy riel@redhat.com - 2016-02-01 20:30 +0100
  Re: [PATCH 4/4] sched,time: only call  account_{user,sys,guest,idle}_time once a jiffy Rik van Riel <riel@redhat.com> - 2016-02-01 21:10 +0100
  Re: [PATCH 4/4] sched,time: only call  account_{user,sys,guest,idle}_time once a jiffy Eric Dumazet <eric.dumazet@gmail.com> - 2016-02-01 21:10 +0100

csiph-web