Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323303

Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver

From Eric Auger <eric.auger@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver
Date 2016-02-01 17:40 +0100
Message-ID <qXpGa-5BS-13@gated-at.bofh.it> (permalink)
References <qWpRU-1uc-13@gated-at.bofh.it> <qWpRU-1uc-23@gated-at.bofh.it> <qXpd9-5p0-33@gated-at.bofh.it> <qXpmO-5sL-29@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 02/01/2016 05:16 PM, Sinan Kaya wrote:
> On 2/1/2016 11:08 AM, Eric Auger wrote:
>>> For ACPI systems, ACPI HID needs to match and compat in the registered
>>>> reset
>>>> driver needs to match for ACPI reset driver loading to work.
>> Don't really get the sentence. For ACPI systems, a registered reset
>> function is selected if its associated ACPI HID matches the device ACPI HID?
> 
> Old commit message. I did an internal review before posting the patch. The first
> version of the patch was a hack. I simplified the code but forgot to update the 
> commit message.
> 
> Now, the rule is simple.
> 
> - ACPI HID needs match for ACPI systems
> - DT compat needs to match for OF systems
> 
> as expected. I'll rephrase for the next version.
> 
>>>>
>>>> For OF based systems, DT compatible string needs to match and compat in the
>>>> registered reset driver needs to match for DT reset driver loading to work.
>> same here
>>
>> I added Baptiste who is vfio platform driver sub-system maintainer.
> 
> Thanks, we should ask Baptiste to get his email into the Maintainer file list.
I think it is:
./scripts/get_maintainer.pl
0001-vfio-platform-add-support-for-ACPI-while-detecting-t.patch

Baptiste Reynal <b.reynal@virtualopensystems.com> (maintainer:VFIO
PLATFORM DRIVER,commit_signer:1/5=20%)
Alex Williamson <alex.williamson@redhat.com> (maintainer:VFIO
DRIVER,commit_signer:2/3=67%,commit_signer:4/5=80%)
../..
> 
>>
>> On my side I tested with of amd xgbe and I don't observe any regression.
>>
>> Best Regards
> 
> Can I add your tested by?
Well to make things clear I did not test the ACPI part. I just can tell
this does not bring any regression on the of part. But I am not against
if you don't find anybody else and you tested the ACPI part ;-)

Best Regards

Eric
> 

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V13 00/10] dma: add Qualcomm Technologies HIDMA driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 10/10] vfio, platform: add QTI HIDMA reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
    Re: [PATCH V13 10/10] vfio, platform: add QTI HIDMA reset driver Eric Auger <eric.auger@linaro.org> - 2016-02-01 16:50 +0100
      Re: [PATCH V13 10/10] vfio, platform: add QTI HIDMA reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-02-01 17:00 +0100
  [PATCH V13 09/10] vfio, platform: add support for ACPI while detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
    Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-31 15:00 +0100
    Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Eric Auger <eric.auger@linaro.org> - 2016-02-01 17:10 +0100
      Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-02-01 17:20 +0100
        Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Eric Auger <eric.auger@linaro.org> - 2016-02-01 17:40 +0100
          Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-02-01 17:50 +0100
            Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Timur Tabi <timur@codeaurora.org> - 2016-02-01 17:50 +0100
              Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-02-01 18:00 +0100
          Re: [PATCH V13 09/10] vfio, platform: add support for ACPI while  detecting the reset driver Sinan Kaya <okaya@codeaurora.org> - 2016-02-03 19:40 +0100
  [PATCH V13 06/10] dma: qcom_hidma: add debugfs hooks Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 05/10] dma: qcom_hidma: implement lower level hardware interface Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 03/10] dma: add Qualcomm Technologies HIDMA management driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 04/10] dma: add Qualcomm Technologies HIDMA channel driver Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 01/10] dma: qcom_bam_dma: move to qcom directory Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
  [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:40 +0100
    Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Rob Herring <robh@kernel.org> - 2016-02-01 16:20 +0100
      Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-02-03 19:40 +0100
    Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Mark Rutland <mark.rutland@arm.com> - 2016-02-01 16:40 +0100
      Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-02-01 16:50 +0100
      Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-02-03 19:40 +0100
        Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Mark Rutland <mark.rutland@arm.com> - 2016-02-03 19:40 +0100
          Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-02-03 19:50 +0100
          Re: [PATCH V13 08/10] dma: qcom_hidma: read the channel id from HW Sinan Kaya <okaya@codeaurora.org> - 2016-02-07 16:10 +0100
  [PATCH V13 02/10] dma: hidma: Add Device Tree binding Sinan Kaya <okaya@codeaurora.org> - 2016-01-29 23:50 +0100

csiph-web