Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323160

Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set()

Show all headers | View raw

On Sat, 2016-01-30 at 12:54 +0100, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> 
> There is a WARN_ON() in dev_pm_domain_set() that triggers on attempts
> to set the pm_domain pointer for devices with a driver bound.
> 
> However, that WARN_ON() triggers on attempts to clear the pointer
> too and the test it uses is based on checking the device's
> p->knode_driver pointer which still is set when the device bus
> type's/driver's ->remove callback has been executed.  This
> leads to false-positive warnings when bus type code calls
> dev_pm_domain_set() to clear the pm_domain pointer after
> invoking the driver's ->remove() callback.
> 
> To avoid those false-positives, make dev_pm_domain_set() check
> if the pointer passed to it is NULL and skip the warning in
> that case.

Tested on Intel Braswell where modprobe -r sdhci-acpi caused a warning
before this patch.

Tested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> 
> Fixes: 989561de9b51 (PM / Domains: add setter for dev.pm_domain)
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
>  drivers/base/power/common.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux-pm/drivers/base/power/common.c
> ===================================================================
> --- linux-pm.orig/drivers/base/power/common.c
> +++ linux-pm/drivers/base/power/common.c
> @@ -146,7 +146,7 @@ void dev_pm_domain_set(struct device *de
>  	if (dev->pm_domain == pd)
>  		return;
>  
> -	WARN(device_is_bound(dev),
> +	WARN(pd && device_is_bound(dev),
>  	     "PM domains can only be changed for unbound
> devices\n");
>  	dev->pm_domain = pd;
>  	device_pm_check_callbacks(dev);
> 

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-30 13:00 +0100
  Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set() Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-02-01 15:20 +0100
  Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set() Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-03 11:10 +0100
    Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set() "Rafael J. Wysocki" <rafael@kernel.org> - 2016-02-03 13:10 +0100
      Re: [PATCH] PM: Avoid false-positive warnings in dev_pm_domain_set() Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-03 14:20 +0100

csiph-web