Re: [PATCH] PM / Domains: mark genpd_poweron as __maybe_unused

From	Ulf Hansson <ulf.hansson@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / Domains: mark genpd_poweron as __maybe_unused
Date	2016-02-01 15:00 +0100
Message-ID	<qXnbk-3DE-11@gated-at.bofh.it> (permalink)
References	<qXkn7-1my-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 1 February 2016 at 11:38, Arnd Bergmann <arnd@arndb.de> wrote:
> The rework of the power domain code has made the genpd_poweron()
> function local to the file it's defined in, and the only remaining
> caller is conditionally compiled based on CONFIG_PM_GENERIC_DOMAINS_OF,
> so we get a warning when that is disabled:
>
> drivers/base/power/domain.c:234:12: error: 'genpd_poweron' defined but not used [-Werror=unused-function]
>
> This adds a __maybe_unused annotation to the function so gcc can
> figure out by itself that it should silently remove the definition
> in this case.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: ea823c7cbffa ("PM / Domains: Remove pm_genpd_poweron() API")

Arnd,

Thanks for fixing and reporting!

Looking a bit closer to the genpd code in this reagrds, made me
realize that I think there's a better approach to fix this.
Instead of going into the details for how, I decided to send a
separate patch. You are on cc.

"[PATCH] PM / Domains: Silence compiler warning for an unused function".

Kind regards
Uffe

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PM / Domains: mark genpd_poweron as __maybe_unused Arnd Bergmann <arnd@arndb.de> - 2016-02-01 12:00 +0100
  Re: [PATCH] PM / Domains: mark genpd_poweron as __maybe_unused Ulf Hansson <ulf.hansson@linaro.org> - 2016-02-01 15:00 +0100

csiph-web