Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1323167

Re: [PATCH] fix out of bound read in __test_aead()

Show all headers | View raw

On Fri, Jan 29, 2016 at 02:10:09PM +0100, Jerome Marchand wrote:
> __test_aead() reads MAX_IVLEN bytes from template[i].iv, but the
> actual length of the initialisation vector can be shorter.
> The length of the IV is already calculated earlier in the
> function. Let's just reuses that.
> This fix an out-of-bound error detected by KASan.
> 
> Signed-off-by: Jerome Marchand <jmarchan@redhat.com>

This patch creates a new warning that iv_len may be uninitialised.

Please fix this and resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] fix out of bound read in __test_aead() "Jerome Marchand" <jmarchan@redhat.com> - 2016-01-29 14:20 +0100
  Re: [PATCH] fix out of bound read in __test_aead() Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-01 15:30 +0100
    Re: [PATCH] fix out of bound read in __test_aead() Jerome Marchand <jmarchan@redhat.com> - 2016-02-01 16:50 +0100
  [PATCH v2] fix out of bound read in __test_aead() "Jerome Marchand" <jmarchan@redhat.com> - 2016-02-03 14:00 +0100
    Re: [PATCH v2] fix out of bound read in __test_aead() Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 08:50 +0100

csiph-web