Re: [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page()

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page()
Date	Mon, 01 Feb 2016 15:30:02 +0100
Message-ID	<qXnEm-45e-5@gated-at.bofh.it> (permalink)
References	<qXmIi-3oo-13@gated-at.bofh.it> <qXmIj-3oo-21@gated-at.bofh.it>
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=sHt1xCuJZIAoyrl2nZ0s0zuPNwunQkp1yEZX+tH/0CU=; b=dG97mSYiGcuZMyvn3MGiCVmWaf3siDTLqpRY3lhCI+ejHTDRlnxvm3ShF1fgWDOzK4 f/WO0WdamUPxiJWJ8jcV+igo7ABY0Vev7SlHF7W1BdHF4iCKcmbZG6ODk2DW1J8KLugw JO6/eQpxtEOzms3fvfVfBzf1YprB9KONvUURyIdvtXmmCe6mGXVJeBcL1TWvKWhqfZeB pUNnSoObLgI7jTULIQwb4n5OzNJ2KDNcHAOSD1IbGc7sumr/vpi3dhZV04PcN5mdL1aC 0lEeY0hbngQfkFoyOnSiLzTt7wM6+2W7PIUxKX3cgmF2OpyLCYtmV/27kCEMaSpGmAWT So2A==
X-Gm-Message-State	AG10YOT03Fzg0XEZg0uaILZofljsRGp+lvBsCbnICA+tRQxxIWO7/C9+178GLZms7m3olQ==
X-Received	by 10.194.19.164 with SMTP id g4mr22522469wje.120.1454336688193; Mon, 01 Feb 2016 06:24:48 -0800 (PST)
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.24 (2015-08-30)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	13
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, Dmitry Vyukov <dvyukov@google.com>, Vlastimil Babka <vbabka@suse.cz>, David Rientjes <rientjes@google.com>, Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>, linux-mm@kvack.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 1 Feb 2016 15:24:46 +0100
X-Original-Message-ID	<20160201142446.GB24008@dhcp22.suse.cz>
X-Original-References	<1454333169-121369-1-git-send-email-kirill.shutemov@linux.intel.com> <1454333169-121369-2-git-send-email-kirill.shutemov@linux.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1323164

Show key headers only | View raw

On Mon 01-02-16 16:26:08, Kirill A. Shutemov wrote:
> We don't care if there's a tail pages which is not on LRU. We are not
> going to isolate them anyway.

yes we are not going to isolate them but calling this function on a
tail page is wrong in principle, no? PageLRU check is racy outside of
lru_lock so what if we are racing here. I know, highly unlikely but not
impossible. So I am not really sure this is an improvement. When would
we hit this VM_BUG_ON and it wouldn't be a bug or at least suspicious
usage?
-- 
Michal Hocko
SUSE Labs

Thread

[PATCH 0/2] Fix another VM_BUG_ON_PAGE(PageTail(page)) on mbind(2) "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-01 14:30 +0100
  [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-01 14:30 +0100
    Re: [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page() Michal Hocko <mhocko@kernel.org> - 2016-02-01 15:30 +0100
      Re: [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page() "Kirill A. Shutemov" <kirill@shutemov.name> - 2016-02-01 15:40 +0100
        Re: [PATCH 1/2] mm: fix bogus VM_BUG_ON_PAGE() in isolate_lru_page() Michal Hocko <mhocko@kernel.org> - 2016-02-02 14:30 +0100
  [PATCH 2/2] mempolicy: do not try to queue pages from !vma_migratable() "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-02-01 14:30 +0100
    Re: [PATCH 2/2] mempolicy: do not try to queue pages from  !vma_migratable() Andrew Morton <akpm@linux-foundation.org> - 2016-02-01 23:30 +0100

csiph-web