RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers

From	ygardi@codeaurora.org
Newsgroups	linux.kernel
Subject	RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers
Date	2016-02-01 11:50 +0100
Message-ID	<qXkdr-1hA-1@gated-at.bofh.it> (permalink)
References	<qoyNY-35R-5@gated-at.bofh.it> <qoyNZ-35R-47@gated-at.bofh.it> <qqt7r-R4-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

>
>
>> +	cdb_len = min_t(unsigned short, lrbp->cmd->cmd_len, MAX_CDB_SIZE);
>> +	memcpy(ucd_req_ptr->sc.cdb, lrbp->cmd->cmnd, cdb_len);
>> +	if (cdb_len < MAX_CDB_SIZE)
>> +		memset(ucd_req_ptr->sc.cdb + cdb_len, 0,
>> +		       (MAX_CDB_SIZE - cdb_len));
> It's just 16 bytes, setting all to zero prior  to copy will be as good as
> this if statement
> memset(ucd_req_ptr->sc.cdb, 0, MAX_CDB_SIZE);
>

i agree. will be modified in V7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH v6 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before  new transfers ygardi@codeaurora.org - 2016-02-01 11:50 +0100

csiph-web