Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with pr_xx(...)

From	Borislav Petkov <bp@alien8.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with pr_xx(...)
Date	2016-02-01 10:40 +0100
Message-ID	<qXj7I-Bb-3@gated-at.bofh.it> (permalink)
References	<qXi1Y-8lp-7@gated-at.bofh.it> <qXi1Y-8lp-9@gated-at.bofh.it> <qXi1Y-8lp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 01, 2016 at 09:24:12AM +0100, Ingo Molnar wrote:
> > So there are 37,000+ printk() calls in the kernel and 900+ ones in arch/x86/ 
> > alone! Plus even after this patch there's 20 more printk()s left in 
> > arch/x86/kernel/cpu/mcheck/...
> > 
> > We don't want to create a churn of 10,000+ commits to convert them to pr_*() 
> > facilities...
> > 
> > So we don't apply such 'conversion' patches unless it's done for a whole subsystem 
> > and done as part of a larger work with good reason, or if it's done as part of 
> > completely new facilities/drivers - and is done consistently.
> > 
> > Even then it's dubious to convert: people keep re-adding printk()s (which is a 
> > perfectly fine facility), which generates never ending churn ...

Amen to that!

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with  pr_xx(...) Ingo Molnar <mingo@kernel.org> - 2016-02-01 09:30 +0100
  Re: [PATCH] mcheck/therm_throt: Replace printk(KERN_XX...) with  pr_xx(...) Borislav Petkov <bp@alien8.de> - 2016-02-01 10:40 +0100

csiph-web