Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322909

RE: [PATCH] cputime: Fix timeval-->cputime conversion

From Thomas Gleixner <tglx@linutronix.de>
Newsgroups linux.kernel
Subject RE: [PATCH] cputime: Fix timeval-->cputime conversion
Date 2016-02-01 09:50 +0100
Message-ID <qXilk-8sL-5@gated-at.bofh.it> (permalink)
References <qVOSl-8jL-1@gated-at.bofh.it> <qVTp1-2RX-33@gated-at.bofh.it> <qW7Lj-4Yk-11@gated-at.bofh.it> <qWcUH-90-41@gated-at.bofh.it> <qXdOF-55d-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Mon, 1 Feb 2016, Zengtao (B) wrote:

> Hi Arnd:
> 	I have got a new idea about the problem: 
> In include/linux/time64.h
> #define NSEC_PER_SEC	1000000000L 
> I think we should change it to
> #define NSEC_PER_SEC	1000000000LL 
> 
> My reason is :
> 1.  when it is used in a multiplication, it will easily get overflow.
> 2.  when it don't get overflow, the change has no side affect.

That's not a good idea. NSEC_PER_SEC is used in lots of places with 32bit
storage. I really don't want to mop up all the fallout.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cputime: Fix timeval-->cputime conversion zengtao <prime.zeng@huawei.com> - 2016-01-28 08:10 +0100
  Re: [PATCH] cputime: Fix timeval-->cputime conversion Thomas Gleixner <tglx@linutronix.de> - 2016-01-28 09:30 +0100
    Re: [PATCH] cputime: Fix timeval-->cputime conversion Arnd Bergmann <arnd@arndb.de> - 2016-01-28 13:00 +0100
      RE: [PATCH] cputime: Fix timeval-->cputime conversion "Zengtao (B)" <prime.zeng@hisilicon.com> - 2016-01-29 04:20 +0100
        Re: [PATCH] cputime: Fix timeval-->cputime conversion Arnd Bergmann <arnd@arndb.de> - 2016-01-29 09:50 +0100
          RE: [PATCH] cputime: Fix timeval-->cputime conversion "Zengtao (B)" <prime.zeng@hisilicon.com> - 2016-01-30 03:40 +0100
          RE: [PATCH] cputime: Fix timeval-->cputime conversion "Zengtao (B)" <prime.zeng@hisilicon.com> - 2016-02-01 05:00 +0100
            RE: [PATCH] cputime: Fix timeval-->cputime conversion Thomas Gleixner <tglx@linutronix.de> - 2016-02-01 09:50 +0100
              RE: [PATCH] cputime: Fix timeval-->cputime conversion "Zengtao (B)" <prime.zeng@hisilicon.com> - 2016-02-02 04:00 +0100

csiph-web