Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver

From	Peter Hung <hpeter@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver
Date	2016-02-01 04:40 +0100
Message-ID	<qXdvk-4X4-9@gated-at.bofh.it> (permalink)
References	<qVR3Q-1j6-5@gated-at.bofh.it> <qVR3Q-1j6-13@gated-at.bofh.it> <qVTyG-3aT-13@gated-at.bofh.it> <qWcBj-8sE-11@gated-at.bofh.it> <qWgEW-33T-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andy,

Andy Shevchenko 於 2016/1/29 下午 08:40 寫道:
> On Fri, 2016-01-29 at 16:20 +0800, Peter Hung wrote:
>> Hi Andy,
>>
>> Andy Shevchenko 於 2016/1/28 下午 08:04 寫道:
>>> On Thu, 2016-01-28 at 17:20 +0800, Peter Hung wrote:
>>>> -	/* Fintek PCI serial cards */
>>>> -	{ PCI_DEVICE(0x1c29, 0x1104), .driver_data =
>>>> pbn_fintek_4 },
>>>> -	{ PCI_DEVICE(0x1c29, 0x1108), .driver_data =
>>>> pbn_fintek_8 },
>>>> -	{ PCI_DEVICE(0x1c29, 0x1112), .driver_data =
>>>> pbn_fintek_12
>>>> },
>>>
>>> Shouldn't you blacklist them in 8250_pci?
>>>
>>
>> You are referring to add blacklist instead of remove F81504/508/512
>> code?
>
> No.
>
>>   or add blacklist and remove code?
>
> This one.

ok

> Check what lspci tells you about your device. I'm pretty sure that it
> has Serial Class, which would trigger enumeration in 8250_pci.c if it
> comes first.
>

I had add log with 8250_pci.c. It really trigger once by 8250_pci.c,
but will failed with serial_pci_guess_board(). So It can be handled by
f81504-core.c. I should add pid/vid to blacklist and comments it'll
be handled by f81504-core.c

Thanks
-- 
With Best Regards,
Peter Hung

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512 UART driver Peter Hung <hpeter@gmail.com> - 2016-01-28 10:30 +0100
  Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512  UART driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-28 13:10 +0100
    Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512  UART driver Peter Hung <hpeter@gmail.com> - 2016-01-29 09:30 +0100
      Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512  UART driver Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-29 13:50 +0100
        Re: [PATCH V2 4/4] serial: 8250_pci: Remove Fintek F81504/508/512  UART driver Peter Hung <hpeter@gmail.com> - 2016-02-01 04:40 +0100

csiph-web