Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322779

Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in the debug code

From Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in the debug code
Date 2016-02-01 03:20 +0100
Message-ID <qXcfT-45K-5@gated-at.bofh.it> (permalink)
References <qWgEW-33T-3@gated-at.bofh.it> <qWgOC-3ad-9@gated-at.bofh.it> <qWZsm-3hB-11@gated-at.bofh.it> <qXbMR-3Fa-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On (02/01/16 10:45), Byungchul Park wrote:
> But avoiding an unnecessary recursive cycle is better than panic(). What I handled
> in this patch is the warning case which causes unnecessary lockup and don't need to
> happen.

Hello,

correct, that was one of the reasons why I proposed to
return back to discussion. it's a bit hard to tell if
we have any chance to survive a "lockup suspected"
spin_dump() recursion; even if we have one, it's a race
spin_unlock on CPUA vs. stack overflow on CPUB. we can
be more certain with ->magic mismatch, for example, but
"lockup suspected" is tricky.

	-ss

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in the debug code Byungchul Park <byungchul.park@lge.com> - 2016-01-29 13:50 +0100
  Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Byungchul Park <byungchul.park@lge.com> - 2016-01-29 14:00 +0100
    Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-01-31 13:40 +0100
      Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Byungchul Park <byungchul.park@lge.com> - 2016-02-01 02:50 +0100
        Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-01 03:20 +0100
  Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Ingo Molnar <mingo@kernel.org> - 2016-01-30 10:30 +0100
    Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Byungchul Park <byungchul.park@lge.com> - 2016-02-02 03:40 +0100
  Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> - 2016-02-01 03:40 +0100
    Re: [PATCH v5] lib/spinlock_debug.c: prevent a recursive cycle in  the debug code Byungchul Park <byungchul.park@lge.com> - 2016-02-01 07:30 +0100

csiph-web