Re: [RFC PATCH] alispinlock: acceleration from lock integration on multi-core platform

From	Ling Ma <ling.ma.program@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] alispinlock: acceleration from lock integration on multi-core platform
Date	2016-02-03 05:50 +0100
Message-ID	<qXXya-5xy-1@gated-at.bofh.it> (permalink)
References	(6 earlier) <qOO14-4T5-1@gated-at.bofh.it> <qQ7En-1Fv-21@gated-at.bofh.it> <qQLip-4lJ-3@gated-at.bofh.it> <qSAiS-5me-27@gated-at.bofh.it> <qSGxY-1lu-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Longman,

The attachment include user space code(thread.c), and kernel
patch(ali_work_queue.patch) based on 4.3.0-rc4,
we replaced all original spinlock (list_lock) in slab.h/c  with the
new mechanism.

The thread.c in user space caused lots of hot kernel spinlock from
__kmalloc and kfree,
perf top -d1 shows ~25%  before ali_work_queue.patch,after appending
this patch ,
the synchronous operation consumption from __kmalloc and kfree is
reduced from 25% to ~15% on Intel E5-2699V3
(we also observed the output from user space code (thread.c) is
improved clearly)

Peter, we will send the update version according to your comments.

Thanks
Ling


2016-01-19 23:36 GMT+08:00 Waiman Long <waiman.long@hpe.com>:
> On 01/19/2016 03:52 AM, Ling Ma wrote:
>>
>> Is it acceptable for performance improvement or more comments on this
>> patch?
>>
>> Thanks
>> Ling
>>
>>
>
> Your alispinlock patchset should also include a use case where the lock is
> used by some code within the kernel with test that can show a performance
> improvement so that the reviewers can independently try it out and play
> around with it. The kernel community will not accept any patch without a use
> case in the kernel.
>
> Your lock_test.tar file is not good enough as it is not a performance test
> of the patch that you sent out.
>
> Cheers,
> Longman

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] alispinlock: acceleration from lock integration on  multi-core platform Ling Ma <ling.ma.program@gmail.com> - 2016-02-03 05:50 +0100
  Re: [RFC PATCH] alispinlock: acceleration from lock integration on  multi-core platform Ling Ma <ling.ma.program@gmail.com> - 2016-02-03 07:10 +0100
  Re: [RFC PATCH] alispinlock: acceleration from lock integration on  multi-core platform Waiman Long <waiman.long@hpe.com> - 2016-02-03 22:50 +0100
    Re: [RFC PATCH] alispinlock: acceleration from lock integration on  multi-core platform Ling Ma <ling.ma.program@gmail.com> - 2016-02-04 08:10 +0100

csiph-web