Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324760

Re: [PATCH] davinci:Fix possible NULL pointer deference in the function davinci_gpio_probe

Show key headers only | View raw

On Wed, Feb 3, 2016 at 9:17 AM, Nicholas Krause <xerofoify@gmail.com> wrote:
> This fixes a possible NULL pointer deference in the function,
> davinci_gpio_probe due to the function, gpio2regs being able
> to return a NULL pointer if it rans to get the registers for
> the gpio devices on a davinci board. Furthermore if this does
> arise return -ENXIO to signal callers that this case has arisen
> and avoiding setting the regs or other pointer values on the
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
>  drivers/gpio/gpio-davinci.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index ec58f42..1cc527d 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -257,6 +257,8 @@ static int davinci_gpio_probe(struct platform_device *pdev)
>                 spin_lock_init(&chips[i].lock);
>
>                 regs = gpio2regs(base);
> +               if (!regs)
> +                       return -ENXIO;

Ok, a bit futile maybe but this *may* happen in theory...

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] davinci:Fix possible NULL pointer deference in the  function davinci_gpio_probe Alexandre Courbot <gnurou@gmail.com> - 2016-02-03 01:30 +0100

csiph-web