Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1324756
| From | Alexandre Courbot <gnurou@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 0/7] Use devm_request_region |
| Date | 2016-02-03 01:30 +0100 |
| Message-ID | <qXTuy-2P5-3@gated-at.bofh.it> (permalink) |
| References | <qXwxZ-1Yg-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Feb 2, 2016 at 8:54 AM, William Breathitt Gray <vilhelm.gray@gmail.com> wrote: > By the time request_region is called in several GPIO drivers, a > corresponding device structure has already been allocated. The > devm_request_region function should be used to help simplify the cleanup > code and reduce the possible points of failure. > > William Breathitt Gray (7): > gpio: 104-dio-48e: Use devm_request_region > gpio: 104-idi-48: Use devm_request_region > gpio: 104-idio-16: Use devm_request_region > gpio: amd8111: Use devm_request_region > gpio: ich: Use devm_request_region > gpio: sch311x: Use devm_request_region > gpio: ws16c48: Use devm_request_region > > drivers/gpio/gpio-104-dio-48e.c | 22 +++++++----------- > drivers/gpio/gpio-104-idi-48.c | 22 +++++++----------- > drivers/gpio/gpio-104-idio-16.c | 22 +++++++----------- > drivers/gpio/gpio-amd8111.c | 7 +++--- > drivers/gpio/gpio-ich.c | 51 ++++++++--------------------------------- > drivers/gpio/gpio-sch311x.c | 7 +++--- > drivers/gpio/gpio-ws16c48.c | 22 +++++++----------- > 7 files changed, 47 insertions(+), 106 deletions(-) Did a quick review and this looks all good, modulo the compile warning on patch 6. Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/7] Use devm_request_region William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-02-02 01:00 +0100
[PATCH 2/7] gpio: 104-idi-48: Use devm_request_region William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-02-02 01:00 +0100
[PATCH 3/7] gpio: 104-idio-16: Use devm_request_region William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-02-02 01:00 +0100
[PATCH 4/7] gpio: amd8111: Use devm_request_region William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-02-02 01:00 +0100
Re: [PATCH 0/7] Use devm_request_region Alexandre Courbot <gnurou@gmail.com> - 2016-02-03 01:30 +0100
Re: [PATCH 0/7] Use devm_request_region William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-02-03 01:50 +0100
csiph-web