Re: [PATCH v6] kernel: add kcov code coverage

From	Jiri Slaby <jslaby@suse.cz>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] kernel: add kcov code coverage
Date	2016-02-02 18:20 +0100
Message-ID	<qXMMr-6gE-23@gated-at.bofh.it> (permalink)
References	<qUP46-4jX-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/25/2016, 02:00 PM, Dmitry Vyukov wrote:
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -136,6 +136,12 @@ _c_flags += $(if $(patsubst n%,, \
>  		$(CFLAGS_UBSAN))
>  endif
>  
> +ifeq ($(CONFIG_KCOV),y)
> +_c_flags += $(if $(patsubst n%,, \
> +	$(KCOV_INSTRUMENT_$(basetarget).o)$(KCOV_INSTRUMENT)y), \
> +	$(CFLAGS_KCOV))

Now that KCOV does not inherit KASAN's "n"s, I see link errors in efi
lib with EFI_STUB:
drivers/firmware/efi/libstub/lib.a(efi-stub-helper.o): In function
`efi_printk':
efi-stub-helper.c:(.text+0x13): undefined reference to
`__sanitizer_cov_trace_pc'
efi-stub-helper.c:(.text+0x31): undefined reference to
`__sanitizer_cov_trace_pc'
...

I fixed it by adding "KCOV_INSTRUMENT := n" to
  drivers/firmware/efi/libstub/Makefile

thanks,
-- 
js
suse labs

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] kernel: add kcov code coverage Jiri Slaby <jslaby@suse.cz> - 2016-02-02 18:20 +0100
  Re: [PATCH v6] kernel: add kcov code coverage Dmitry Vyukov <dvyukov@google.com> - 2016-02-04 16:10 +0100

csiph-web