Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1324199

Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export()

From Rui Wang <rui.y.wang@intel.com>
Newsgroups linux.kernel
Subject Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export()
Date 2016-02-02 16:30 +0100
Message-ID <qXL3Y-4VX-17@gated-at.bofh.it> (permalink)
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Feb 2, 2016 10:45 PM Herbert Xu wrote:
>
> On Tue, Feb 02, 2016 at 10:16:34PM +0800, Rui Wang wrote:
> >
> > I initially made it unconditional, but then I found that it can easily
> > hang the machine during boot due to any import/export bug in any of
> > the hash drivers. So I used this .partial flag to guard against this
> > risk. Only when an author is confident that his driver can do this
> > test, should he add this flag. What do you think?
> 
> Well if they're buggy they may crash anyway.  Considering that all the buggy
> drivers have probably been disabled for the time being I'd say let's make it
> unconditional.

You are right the ahash drivers are already disabled. The shash drivers using
cryptd or mcryptd are probably OK by now. I'll do some tests.

Thanks
Rui 

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export() Rui Wang <rui.y.wang@intel.com> - 2016-02-02 16:30 +0100

csiph-web