Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324170

[PATCH v2] EDAC, mpc85xx: fix build warning

Show all headers | View raw

We were getting build warning about:
drivers/edac/mpc85xx_edac.c:1247:6: warning: unused variable 'pvr'

pvr is only used if CONFIG_FSL_SOC_BOOKE was defined. Remove the
variable pvr and issue mfspr directly.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---

v2: removed variable pvr

 drivers/edac/mpc85xx_edac.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
index b7139c1..f756b62 100644
--- a/drivers/edac/mpc85xx_edac.c
+++ b/drivers/edac/mpc85xx_edac.c
@@ -1244,7 +1244,6 @@ static struct platform_driver * const drivers[] = {
 static int __init mpc85xx_mc_init(void)
 {
 	int res = 0;
-	u32 pvr = 0;
 
 	printk(KERN_INFO "Freescale(R) MPC85xx EDAC driver, "
 	       "(C) 2006 Montavista Software\n");
@@ -1264,10 +1263,8 @@ static int __init mpc85xx_mc_init(void)
 		printk(KERN_WARNING EDAC_MOD_STR "drivers fail to register\n");
 
 #ifdef CONFIG_FSL_SOC_BOOKE
-	pvr = mfspr(SPRN_PVR);
-
-	if ((PVR_VER(pvr) == PVR_VER_E500V1) ||
-	    (PVR_VER(pvr) == PVR_VER_E500V2)) {
+	if ((PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V1) ||
+	    (PVR_VER(mfspr(SPRN_PVR)) == PVR_VER_E500V2)) {
 		/*
 		 * need to clear HID1[RFXE] to disable machine check int
 		 * so we can catch it
-- 
1.9.1

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v2] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 15:50 +0100

csiph-web