Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1324137

[PATCH 2/2] drm/i915/skl: Explicitly check for eDP in skl_ddi_pll_select()

From Lyude <cpaul@redhat.com>
Newsgroups linux.kernel
Subject [PATCH 2/2] drm/i915/skl: Explicitly check for eDP in skl_ddi_pll_select()
Date 2016-02-02 15:40 +0100
Message-ID <qXKhB-4fv-45@gated-at.bofh.it> (permalink)
References <qXKhz-4fv-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Assuming any connector that isn't DP, MST, or HDMI is eDP definitely
seems likely to cover up other bugs in the future.

Signed-off-by: Lyude <cpaul@redhat.com>
---
 drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index 54a165b..e2adc380 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1604,8 +1604,10 @@ skl_ddi_pll_select(struct intel_crtc *intel_crtc,
 		}
 
 		cfgcr1 = cfgcr2 = 0;
-	} else /* eDP */
+	} else if (intel_encoder->type == INTEL_OUTPUT_EDP) {
 		return true;
+	} else
+		return false;
 
 	memset(&crtc_state->dpll_hw_state, 0,
 	       sizeof(crtc_state->dpll_hw_state));
-- 
2.5.0

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] drm/i915/skl: Don't skip mst encoders in skl_ddi_pll_select() Lyude <cpaul@redhat.com> - 2016-02-02 15:40 +0100
  [PATCH 2/2] drm/i915/skl: Explicitly check for eDP in skl_ddi_pll_select() Lyude <cpaul@redhat.com> - 2016-02-02 15:40 +0100
  Re: [PATCH 1/2] drm/i915/skl: Don't skip mst encoders in skl_ddi_pll_select() Jani Nikula <jani.nikula@linux.intel.com> - 2016-02-02 16:20 +0100
    [PATCH v2 1/2] drm/i915/skl: Don't skip mst encoders in skl_ddi_pll_select() Lyude <cpaul@redhat.com> - 2016-02-02 16:50 +0100

csiph-web