Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export()

From	Rui Wang <rui.y.wang@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export()
Date	2016-02-02 15:40 +0100
Message-ID	<qXKhA-4fv-27@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Feb 1, 2016 4:22 PM Herbert Xu wrote:
> 
> On Wed, Jan 27, 2016 at 05:08:38PM +0800, Rui Wang wrote:
> >
> > diff --git a/crypto/testmgr.h b/crypto/testmgr.h index
> > da0a8fd..451e7eb 100644
> > --- a/crypto/testmgr.h
> > +++ b/crypto/testmgr.h
> > @@ -44,6 +44,7 @@ struct hash_testvec {
> >  	unsigned short psize;
> >  	unsigned char np;
> >  	unsigned char ksize;
> > +	unsigned char partial;
> 
> Why not make it unconditional?
> 

I initially made it unconditional, but then I found that it can easily
hang the machine during boot due to any import/export bug in any of
the hash drivers. So I used this .partial flag to guard against this
risk. Only when an author is confident that his driver can do this
test, should he add this flag. What do you think?

Thanks
Rui

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for import()/export() Rui Wang <rui.y.wang@intel.com> - 2016-02-02 15:40 +0100
  Re: [PATCH v2 4/4] crypto: testmgr - Add a test case for  import()/export() Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-02 15:50 +0100
    [PATCH v3 4/4] crypto: testmgr - Add a test case for import()/export() Rui Wang <rui.y.wang@intel.com> - 2016-02-03 11:50 +0100
      Re: [PATCH v3 4/4] crypto: testmgr - Add a test case for  import()/export() Herbert Xu <herbert@gondor.apana.org.au> - 2016-02-06 08:50 +0100

csiph-web