Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324131

Re: [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection

Show all headers | View raw

On Fri, Jan 29, 2016 at 12:54:07PM -0500, Johannes Weiner wrote:
> Cache thrash detection (see a528910e12ec "mm: thrash detection-based
> file cache sizing" for details) currently only works on the system
> level, not inside cgroups. Worse, as the refaults are compared to the
> global number of active cache, cgroups might wrongfully get all their
> refaults activated when their pages are hotter than those of others.
> 
> Move the refault machinery from the zone to the lruvec, and then tag
> eviction entries with the memcg ID. This makes the thrash detection
> work correctly inside cgroups.
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Reviewed-by: Vladimir Davydov <vdavydov@virtuozzo.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 0/5] mm: workingset: per-cgroup thrash detection Johannes Weiner <hannes@cmpxchg.org> - 2016-01-29 19:00 +0100
  [PATCH v2 1/5] mm: memcontrol: generalize locking for the page->mem_cgroup binding Johannes Weiner <hannes@cmpxchg.org> - 2016-01-29 19:00 +0100
    Re: [PATCH v2 1/5] mm: memcontrol: generalize locking for the  page->mem_cgroup binding Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-02-02 15:20 +0100
  [PATCH v2 2/5] mm: workingset: #define radix entry eviction mask Johannes Weiner <hannes@cmpxchg.org> - 2016-01-29 19:00 +0100
  [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection Johannes Weiner <hannes@cmpxchg.org> - 2016-01-29 19:00 +0100
    Re: [PATCH v2 5/5] mm: workingset: per-cgroup cache thrash detection Vladimir Davydov <vdavydov@virtuozzo.com> - 2016-02-02 15:40 +0100
  [PATCH v2 3/5] mm: workingset: separate shadow unpacking and refault calculation Johannes Weiner <hannes@cmpxchg.org> - 2016-01-29 19:00 +0100

csiph-web