Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1324192

Re: [PATCH] EDAC, mpc85xx: fix build warning

From Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] EDAC, mpc85xx: fix build warning
Date 2016-02-02 16:20 +0100
Message-ID <qXKUi-4Qa-23@gated-at.bofh.it> (permalink)
References (3 earlier) <qXKrg-4kd-17@gated-at.bofh.it> <qXKAW-4oM-17@gated-at.bofh.it> <qXKKB-4KV-11@gated-at.bofh.it> <qXKUh-4Qa-1@gated-at.bofh.it> <qXKUi-4Qa-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Feb 02, 2016 at 04:15:43PM +0100, Borislav Petkov wrote:
> On Tue, Feb 02, 2016 at 08:43:57PM +0530, Sudip Mukherjee wrote:
> > another way might be:
> > 
> > diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
> > index b7139c1..968c0c0 100644
> > --- a/drivers/edac/mpc85xx_edac.c
> > +++ b/drivers/edac/mpc85xx_edac.c
> > @@ -1244,7 +1244,9 @@ static struct platform_driver * const drivers[] = {
> >  static int __init mpc85xx_mc_init(void)
> >  {
> >  	int res = 0;
> > +#ifdef CONFIG_FSL_SOC_BOOKE
> >  	u32 pvr = 0;
> > +#endif
> 
> Nah, this is the ugliest of them all. We want less ifdeffery, not more.

ok, i am resending with  __maybe_unused

regards
sudip

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 09:10 +0100
  Re: [PATCH] EDAC, mpc85xx: fix build warning Borislav Petkov <bp@alien8.de> - 2016-02-02 12:20 +0100
    Re: [PATCH] EDAC, mpc85xx: fix build warning Guenter Roeck <linux@roeck-us.net> - 2016-02-02 15:40 +0100
      Re: [PATCH] EDAC, mpc85xx: fix build warning Johannes Thumshirn <jthumshirn@suse.de> - 2016-02-02 15:50 +0100
        Re: [PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 16:00 +0100
          Re: [PATCH] EDAC, mpc85xx: fix build warning Borislav Petkov <bp@alien8.de> - 2016-02-02 16:10 +0100
            Re: [PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 16:20 +0100
              Re: [PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 16:20 +0100
              Re: [PATCH] EDAC, mpc85xx: fix build warning Borislav Petkov <bp@alien8.de> - 2016-02-02 16:20 +0100
    Re: [PATCH] EDAC, mpc85xx: fix build warning Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-02-02 15:50 +0100

csiph-web