Re: 答复: [PATCH] signal: use sizeof() instead of sizeof

From	Richard Weinberger <richard@nod.at>
Newsgroups	linux.kernel
Subject	Re: 答复: [PATCH] signal: use sizeof() instead of sizeof
Date	2016-02-02 09:20 +0100
Message-ID	<qXElQ-84M-5@gated-at.bofh.it> (permalink)
References	<qXDSO-7AO-17@gated-at.bofh.it> <qXE2u-7EE-5@gated-at.bofh.it> <qXElQ-84M-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am 02.02.2016 um 09:08 schrieb Wei Tang:
> This is a simple patch, just to clear up the output from checkpatch.pl
> script, otherwise, we will get WARNING always.

This does not answer my question.
What problem does it fix? How does your patch make the kernel better?

Doing patches just because of checkpatch warnings (not errors)
is IMHO not good.
It is a script and not human, it does not understand all the corner cases.
All it can do is giving us hints. But this does not mean that you have to
blindly follow them.

Thanks,
//richard

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] signal: use sizeof() instead of sizeof Wei Tang <tangwei@cmss.chinamobile.com> - 2016-02-02 08:50 +0100
  Re: [PATCH] signal: use sizeof() instead of sizeof Richard Weinberger <richard@nod.at> - 2016-02-02 09:00 +0100
    Re: 答复: [PATCH] signal: use sizeof() instead of sizeof Richard Weinberger <richard@nod.at> - 2016-02-02 09:20 +0100

csiph-web