Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1323778

Re: [PATCH] netfilter: nft_ct: define nft_ct_get_eval_counter() only when needed

From Florian Westphal <fw@strlen.de>
Newsgroups linux.kernel
Subject Re: [PATCH] netfilter: nft_ct: define nft_ct_get_eval_counter() only when needed
Date 2016-02-02 05:20 +0100
Message-ID <qXABz-5fp-1@gated-at.bofh.it> (permalink)
References <qXz2P-3Wf-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Eric Biggers <ebiggers3@gmail.com> wrote:
> This eliminates an "unused function" compiler warning when
> CONFIG_NF_CONNTRACK_LABELS is not defined.
> 
> Signed-off-by: Eric Biggers <ebiggers3@gmail.com>

The nft_ct_get_eval_counter call should've been unconditional.
The #endif placement is wrong:

https://git.kernel.org/cgit/linux/kernel/git/davem/net.git/commit?id=efaea94aaf0decd55b15aa7068d4d516a352e56e

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] netfilter: nft_ct: define nft_ct_get_eval_counter() only when needed Eric Biggers <ebiggers3@gmail.com> - 2016-02-02 03:40 +0100
  Re: [PATCH] netfilter: nft_ct: define nft_ct_get_eval_counter() only  when needed Florian Westphal <fw@strlen.de> - 2016-02-02 05:20 +0100

csiph-web