Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1322730

Re: [PATCH v5 00/10] virtio DMA API, yet again

Show all headers | View raw

On Sun, Jan 31, 2016 at 12:12 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> On Thu, Jan 28, 2016 at 06:31:13PM -0800, Andy Lutomirski wrote:
>> This switches virtio to use the DMA API on Xen and if requested by
>> module option.
>>
>> This fixes virtio on Xen, and it should break anything because it's
>> off by default on everything except Xen PV on x86.
>>
>> To the Xen people: is this okay?  If it doesn't work on other Xen
>> variants (PVH? HVM?), can you submit follow-up patches to fix it?
>>
>> To everyone else: we've waffled on this for way too long.  I think
>> we should to get DMA API implementation in with a conservative
>> policy like this rather than waiting until we achieve perfection.
>> I'm tired of carrying these patches around.
>
> I agree, thanks for working on this!
>
>> Michael, if these survive review, can you stage these in your tree?
>
> Yes, I'll stage everything except 10/10. I'd rather not maintain a
> module option like this, things work for now and I'm working on a
> clean solution for things like dpdk within guest.

The module option was mainly for testing, but patching in a "return
true" works just as well.

I ran the code through the DMA API debugging stuff and swiotlb=force
with the module option set under KVM (no Xen), and everything seemed
to work.

--Andy

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v5 00/10] virtio DMA API, yet again Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 01/10] dma: Provide simple noop dma ops Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 07/10] virtio_mmio: Use the DMA API if enabled Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 08/10] virtio_pci: Use the DMA API if enabled Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 06/10] virtio: Add improved queue allocation API Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 04/10] vring: Introduce vring_use_dma_api() Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
    Re: [PATCH v5 04/10] vring: Introduce vring_use_dma_api() David Woodhouse <dwmw2@infradead.org> - 2016-02-01 12:30 +0100
      Re: [PATCH v5 04/10] vring: Introduce vring_use_dma_api() "Michael S. Tsirkin" <mst@redhat.com> - 2016-02-01 14:30 +0100
        Re: [PATCH v5 04/10] vring: Introduce vring_use_dma_api() Andy Lutomirski <luto@amacapital.net> - 2016-02-01 16:50 +0100
          Re: [PATCH v5 04/10] vring: Introduce vring_use_dma_api() David Woodhouse <dwmw2@infradead.org> - 2016-02-01 17:20 +0100
  [PATCH v5 03/10] s390/dma: Allow per device dma ops Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 02/10] alpha/dma: use common noop dma ops Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  [PATCH v5 05/10] virtio_ring: Support DMA APIs Andy Lutomirski <luto@kernel.org> - 2016-01-29 03:40 +0100
  Re: [PATCH v5 00/10] virtio DMA API, yet again David Woodhouse <dwmw2@infradead.org> - 2016-01-29 12:10 +0100
    Re: [PATCH v5 00/10] virtio DMA API, yet again Christoph Hellwig <hch@lst.de> - 2016-01-31 20:10 +0100
  Re: [PATCH v5 00/10] virtio DMA API, yet again "Michael S. Tsirkin" <mst@redhat.com> - 2016-01-31 21:20 +0100
    Re: [PATCH v5 00/10] virtio DMA API, yet again Andy Lutomirski <luto@amacapital.net> - 2016-01-31 21:20 +0100
  Re: [Xen-devel] [PATCH v5 00/10] virtio DMA API, yet again Wei Liu <wei.liu2@citrix.com> - 2016-02-01 12:10 +0100
    Re: [Xen-devel] [PATCH v5 00/10] virtio DMA API, yet again Andy Lutomirski <luto@amacapital.net> - 2016-02-01 19:10 +0100
      Re: [Xen-devel] [PATCH v5 00/10] virtio DMA API, yet again Wei Liu <wei.liu2@citrix.com> - 2016-02-01 22:30 +0100

csiph-web