Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1322145

Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping

From Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Newsgroups linux.kernel
Subject Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource mapping
Date 2016-01-29 23:40 +0100
Message-ID <qWpRT-1uc-9@gated-at.bofh.it> (permalink)
References <qWbvA-7JV-17@gated-at.bofh.it> <qWo9s-eo-7@gated-at.bofh.it> <qWpIe-1q3-11@gated-at.bofh.it> <qWpIe-1q3-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Jan 29, 2016 at 02:26:54PM -0800, Jarkko Sakkinen wrote:
> On Fri, Jan 29, 2016 at 02:21:08PM -0800, Jarkko Sakkinen wrote:
> > On Fri, Jan 29, 2016 at 01:48:27PM -0700, Jason Gunthorpe wrote:
> > > On Thu, Jan 28, 2016 at 11:13:59PM -0800, Jarkko Sakkinen wrote:
> > > 
> > > > -	struct resource tmp = {};
> > > > -
> > > > -	tmp.start = start;
> > > > -	tmp.end = start + size - 1;
> > > > -	tmp.flags = IORESOURCE_MEM;
> > > > +	struct resource new_res = {
> > > > +		.start	= start,
> > > > +		.end	= size - 1,
> > > 
> > > That isn't right.
> > 
> > Whoops. Good catch, I'll update it before pull request. Thanks!
> 
> github.com/jsakkine/linux-tpmdd/commit/5012960093774c49d81c612eb32f92cfa1f619bc
> 
> struct resource new_res = {
> 	.start	= start,
> 	.end	= start + size - 1,
> 	.flags	= IORESOURCE_MEM,
> };
> 
> Better?

Yes that looks ok

Jason

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] tpm, tpm_crb: fix control area resource mapping Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-29 08:20 +0100
  Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource  mapping Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-29 21:50 +0100
    Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource  mapping Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-29 23:30 +0100
      Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource  mapping Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-29 23:40 +0100
      Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource  mapping Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-29 23:40 +0100
    Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: fix control area resource  mapping Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> - 2016-01-29 23:30 +0100

csiph-web