[PATCH] i2c: designware: balance clk enable/disable on removal

From	Alexey Khoroshilov <khoroshilov@ispras.ru>
Newsgroups	linux.kernel
Subject	[PATCH] i2c: designware: balance clk enable/disable on removal
Date	2016-01-29 23:40 +0100
Message-ID	<qWpRT-1uc-5@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

It seems clk_disable_unprepare() is missed in dw_i2c_plat_remove(),
so the patch adds it.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
---
 drivers/i2c/busses/i2c-designware-platdrv.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-designware-platdrv.c b/drivers/i2c/busses/i2c-designware-platdrv.c
index 438f1b4964c0..8f19b7b81fe0 100644
--- a/drivers/i2c/busses/i2c-designware-platdrv.c
+++ b/drivers/i2c/busses/i2c-designware-platdrv.c
@@ -267,6 +267,7 @@ static int dw_i2c_plat_remove(struct platform_device *pdev)
 	i2c_del_adapter(&dev->adapter);
 
 	i2c_dw_disable(dev);
+	i2c_dw_plat_prepare_clk(dev, false);
 
 	pm_runtime_dont_use_autosuspend(&pdev->dev);
 	pm_runtime_put_sync(&pdev->dev);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] i2c: designware: balance clk enable/disable on removal Alexey Khoroshilov <khoroshilov@ispras.ru> - 2016-01-29 23:40 +0100
  Re: [PATCH] i2c: designware: balance clk enable/disable on removal Jarkko Nikula <jarkko.nikula@linux.intel.com> - 2016-02-01 15:30 +0100
    Re: [PATCH] i2c: designware: balance clk enable/disable on removal Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-02-01 15:50 +0100

csiph-web