Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321996
| From | Tejun Heo <tj@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH wq/for-4.5-fixes] workqueue: skip flush dependency checks for legacy workqueues |
| Date | 2016-01-29 19:40 +0100 |
| Message-ID | <qWm7E-7g4-35@gated-at.bofh.it> (permalink) |
| References | (4 earlier) <qBDGa-6Nq-19@gated-at.bofh.it> <qBDGa-6Nq-17@gated-at.bofh.it> <qBHJL-QO-1@gated-at.bofh.it> <qVfKW-7rW-13@gated-at.bofh.it> <qWf6a-1Wx-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Jan 29, 2016 at 05:59:46AM -0500, Tejun Heo wrote:
> fca839c00a12 ("workqueue: warn if memory reclaim tries to flush
> !WQ_MEM_RECLAIM workqueue") implemented flush dependency warning which
> triggers if a PF_MEMALLOC task or WQ_MEM_RECLAIM workqueue tries to
> flush a !WQ_MEM_RECLAIM workquee.
>
> This assumes that workqueues marked with WQ_MEM_RECLAIM sit in memory
> reclaim path and making it depend on something which may need more
> memory to make forward progress can lead to deadlocks. Unfortunately,
> workqueues created with the legacy create*_workqueue() interface
> always have WQ_MEM_RECLAIM regardless of whether they are depended
> upon memory reclaim or not. These spurious WQ_MEM_RECLAIM markings
> cause spurious triggering of the flush dependency checks.
...
Applied to wq/for-4.5-fixes.
Thanks.
--
tejun
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH wq/for-4.5-fixes] workqueue: skip flush dependency checks for legacy workqueues Tejun Heo <tj@kernel.org> - 2016-01-29 12:10 +0100 Re: [PATCH wq/for-4.5-fixes] workqueue: skip flush dependency checks for legacy workqueues Thierry Reding <thierry.reding@gmail.com> - 2016-01-29 16:10 +0100 Re: [PATCH wq/for-4.5-fixes] workqueue: skip flush dependency checks for legacy workqueues Tejun Heo <tj@kernel.org> - 2016-01-29 19:40 +0100 Re: [PATCH wq/for-4.5-fixes] workqueue: skip flush dependency checks for legacy workqueues Archit Taneja <architt@codeaurora.org> - 2016-02-02 08:00 +0100
csiph-web