Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321863
| From | Harald Geyer <harald@ccbib.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() |
| Date | 2016-01-29 17:30 +0100 |
| Message-ID | <qWk5P-5O3-9@gated-at.bofh.it> (permalink) |
| References | <qW13b-a7-3@gated-at.bofh.it> <qW13c-a7-13@gated-at.bofh.it> <qW3Ro-28Y-39@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Mark Brown writes: > On Thu, Jan 28, 2016 at 07:55:17PM +0000, Harald Geyer wrote: > > The data structures either have been copied in > > of_get_gpio_regulator_config() already or are part of platform data, > > which we keep a pointer to for the life time of the device anyway. > > The point of this code is to avoid referring to platform data after > probe for robustness. Well, if we can't rely on platform data staying available after probe() then probably we shouldn't keep a pointer to it - but thats a different issue, so lets focus on the original problem: What's your preferred way to fix the error path of probe() then? Harald
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() Harald Geyer <harald@ccbib.org> - 2016-01-28 21:10 +0100
Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() Mark Brown <broonie@kernel.org> - 2016-01-29 00:10 +0100
Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() Harald Geyer <harald@ccbib.org> - 2016-01-29 17:30 +0100
Re: [PATCH 1/2] regulator: gpio: Avoid unnecessarily copying data structures in probe() Mark Brown <broonie@kernel.org> - 2016-02-03 18:30 +0100
csiph-web