Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321774
| From | Daniel Wagner <daniel.wagner@bmw-carit.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH tip v7 1/7] video: Use bool instead int pointer for get_opt_bool() argument |
| Date | 2016-01-29 15:10 +0100 |
| Message-ID | <qWhUp-4fz-55@gated-at.bofh.it> (permalink) |
| References | <qWhUm-4fz-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
As the function name already indicates that get_opt_bool() parses
for a bool. It is not a surprise that compiler is complaining
about it when -Werror=incompatible-pointer-types is used:
drivers/video/fbdev/intelfb/intelfbdrv.c: In function ‘intelfb_setup’:
drivers/video/fbdev/intelfb/intelfbdrv.c:353:39: error: passing argument 3 of ‘get_opt_bool’ from incompatible pointer type [-Werror=incompatible-pointer-types]
if (get_opt_bool(this_opt, "accel", &accel))
Signed-off-by: Daniel Wagner <daniel.wagner@bmw-carit.de>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
---
drivers/video/fbdev/intelfb/intelfbdrv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/fbdev/intelfb/intelfbdrv.c b/drivers/video/fbdev/intelfb/intelfbdrv.c
index bbec737..bf20744 100644
--- a/drivers/video/fbdev/intelfb/intelfbdrv.c
+++ b/drivers/video/fbdev/intelfb/intelfbdrv.c
@@ -302,7 +302,7 @@ static __inline__ int get_opt_int(const char *this_opt, const char *name,
}
static __inline__ int get_opt_bool(const char *this_opt, const char *name,
- int *ret)
+ bool *ret)
{
if (!ret)
return 0;
--
2.5.0
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH tip v7 0/7] Simple wait queue support Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 15:10 +0100 [PATCH tip v7 1/7] video: Use bool instead int pointer for get_opt_bool() argument Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 15:10 +0100 [PATCH tip v7 5/7] KVM: use simple waitqueue for vcpu->wq Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 15:10 +0100 [PATCH tip v7 2/7] MIPS: Differentiate between 32 and 64 bit ELF header Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 15:10 +0100 [PATCH tip v7 7/7] rcu: use simple wait queues where possible in rcutree Daniel Wagner <daniel.wagner@bmw-carit.de> - 2016-01-29 15:10 +0100
csiph-web