Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1321657

Re: [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024

Show all headers | View raw

Thanks Lee for review.
I will take care of most of stuff on next version of patch.

However, I have some query form your comment.
On Friday 29 January 2016 02:36 PM, Lee Jones wrote:
> On Thu, 28 Jan 2016, Laxman Dewangan wrote:
>
>
>> +	}
>> +
>> +#define MAX20024_SUB_MODULE_NO_RES(_name, _id)			\
>> +	[_id] = {						\
>> +		.name = "max20024-"#_name,			\
>> +		.id = _id,					\
>> +	}
> I don't want people hand-rolling this stuff.  If it's useful to you,
> it's useful to others, so great a generic implementation that lives in
> the kernel headers directory.

yaah, generic implementation possible. I can put the new defines in the 
mfd/core.h.

This will be similar to
+/* Define mfd cells with name and resource */
+#define DEFINE_MFD_CELL_NAME_RESOURCE(_name, _res)             \
+       {                                                       \
+               .name = (_name),                                \
+               .num_resources = ARRAY_SIZE((res)),             \
+               .resources = (_res),                            \
+       }
+
+/* Define mfd cells with name */
+#define DEFINE_MFD_CELL_NAME(_name)                            \
+       {                                                       \
+               .name = (_name),                                \
+       }
+

This will be separate patch and should be applied before this series.
Does it look fine?


>
>> +static const struct i2c_device_id max77620_id[] = {
>> +	{"max77620", MAX77620},
>> +	{"max20024", MAX20024},
>> +	{},
>> +};
>> +MODULE_DEVICE_TABLE(i2c, max77620_id);
>> +
>> +static const struct of_device_id max77620_of_match[] = {
>> +	{
>> +		.compatible = "maxim,max77620",
>> +		.data = &max77620_cells,
>> +	}, {
>> +		.compatible = "maxim,max20024",
>> +		.data = &max20024_cells,
>> +	}, {
>> +	},
>> +};
>> +MODULE_DEVICE_TABLE(of, max77620_of_match);
> This is not acceptable.  EITHER use DT OR MFD methods of registering
> devices, do not mix the two.

You mean I need to either provide the i2c_device_id table or the 
of_device_id table, not both?
Do I need to protect it by CONFIG_OF?

This only support the DT method of registration. So do I need to remove 
i2c_device_id?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH V6 0/8] Add support for MAXIM MAX77620/MAX20024 PMIC Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 14:50 +0100
  [PATCH V6 3/8] DT: pinctrl: add DT binding doc for pincontrol of PMIC max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 14:50 +0100
  [PATCH V6 1/8] DT: mfd: add device-tree binding doc for PMIC max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 14:50 +0100
  [PATCH V6 5/8] DT: gpio: add DT binding doc for gpio of PMIC max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 14:50 +0100
  [PATCH V6 4/8] pinctrl: max77620: add pincontrol driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 14:50 +0100
  [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator of PMIC max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 15:00 +0100
    Re: [PATCH V6 7/8] DT: regulator: add DT binding doc for regulator  of PMIC max77620/max20024 Mark Brown <broonie@kernel.org> - 2016-01-29 00:30 +0100
  [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 15:00 +0100
    Re: [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-29 12:20 +0100
      Re: [PATCH V6 2/8] mfd: max77620: add core driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-02-01 10:10 +0100
      Re: [PATCH V6 2/8] mfd: max77620: add core driver for  MAX77620/MAX20024 Lee Jones <lee.jones@linaro.org> - 2016-02-01 10:10 +0100
  [PATCH V6 8/8] regulator: max77620: add regulator driver for max77620/max20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 15:00 +0100
  [PATCH V6 6/8] gpio: max77620: add gpio driver for MAX77620/MAX20024 Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-28 15:00 +0100

csiph-web