Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1321555
| From | Thomas Gleixner <tglx@linutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables() |
| Date | 2016-01-29 09:40 +0100 |
| Message-ID | <qWcL0-5o-3@gated-at.bofh.it> (permalink) |
| References | <qW9aq-5Rj-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Thu, 28 Jan 2016, Shanker Donthineni wrote:
> @@ -807,9 +810,10 @@ static void its_free_tables(struct its_node *its)
> int i;
>
> for (i = 0; i < GITS_BASER_NR_REGS; i++) {
> - if (its->tables[i]) {
> - free_page((unsigned long)its->tables[i]);
> - its->tables[i] = NULL;
> + if (its->tables[i].base) {
> + free_pages((unsigned long)its->tables[i].base,
> + get_order(its->tables[i].size));
> + its->tables[i].base = NULL;
> }
> }
> }
> @@ -880,6 +884,7 @@ retry_alloc_baser:
> if (alloc_pages > GITS_BASER_PAGES_MAX) {
> alloc_pages = GITS_BASER_PAGES_MAX;
> order = get_order(GITS_BASER_PAGES_MAX * psz);
> + alloc_size = (1 << order) * PAGE_SIZE;
Why don't you record the order instead of converting back and forth ?
Thanks,
tglx
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables() Shanker Donthineni <shankerd@codeaurora.org> - 2016-01-29 05:50 +0100
Re: [PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables() Thomas Gleixner <tglx@linutronix.de> - 2016-01-29 09:40 +0100
Re: [PATCH v2] irqchip: gicv3-its: Fix memory leak in its_free_tables() Shanker Donthineni <shankerd@codeaurora.org> - 2016-01-30 02:20 +0100
csiph-web