Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1321530

Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support using managed version
Date 2016-01-29 09:00 +0100
Message-ID <qWc8i-80n-1@gated-at.bofh.it> (permalink)
References <qTRhE-1dO-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Jan 23, 2016 at 02:41:25AM +0530, Shraddha Barke wrote:
> setup_access_params_addr has 2 goals-
> 
> -Initialize the access_params field so that it can be used to send and read
> commands from the device in access_with_param
> -Get a bus address for the allocated memory to transfer to the device.
> 
> Replace the combination of devm_kzalloc and _pa() with dmam_alloc_coherent.
> Coherent mapping guarantees that the device and CPU are in sync.
> 
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> Changes in v3-
>  Both writel in the same style
> Changes in v2-
>  Updated commit message, use upper_32_bits and lower_32_bits
> 
>  drivers/platform/goldfish/goldfish_pipe.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Due to some other changes to this file, this doesn't apply to my
char-misc-testing tree.  Can you refresh it based on that and resend?

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v3] Platform: goldfish: goldfish_pipe.c: Add DMA support  using managed version Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-01-29 09:00 +0100

csiph-web