Re: [PATCH] pinctrl: nomadik: hide unused functions

From	Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: nomadik: hide unused functions
Date	2016-01-29 08:40 +0100
Message-ID	<qWbOW-7Sl-5@gated-at.bofh.it> (permalink)
References	<qURSj-6uy-39@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Arnd,

On Mon, Jan 25, 2016 at 04:59:09PM +0100, Arnd Bergmann wrote:
> The nomadik pinctrl driver has two functions that are only used
> for debugfs output and are otherwise unused:
> 
> drivers/pinctrl/nomadik/pinctrl-abx500.c:194:12: error: 'abx500_get_pull_updown' defined but not used
> drivers/pinctrl/nomadik/pinctrl-abx500.c:471:12: error: 'abx500_get_mode' defined but not used
> 
> This makes the function definitions conditional to avoid the
> harmless warnings.
> [...]
> +#ifdef CONFIG_DEBUG_FS
>  static int abx500_get_pull_updown(struct abx500_pinctrl *pct, int offset,
>  				  enum abx500_gpio_pull_updown *pull_updown)

an alternative is to mark the functions with __maybe_unused. I just
noticed that Documentation/CodingStyle even mandates to use that instead
of cpp stuff.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] pinctrl: nomadik: hide unused functions Uwe Kleine-König   <u.kleine-koenig@pengutronix.de> - 2016-01-29 08:40 +0100

csiph-web